-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and update kube-rbac-proxy and ciphers #224
Fix and update kube-rbac-proxy and ciphers #224
Conversation
Nice! Once green and merged we can continue to actually bump the kube-rbac-proxy fork. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, metalmatze The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
This will update kube-rbac-proxy to v0.4.1.
Is it ok to have these updates in this PR too? I think they only improve stability of the operator.
https://github.com/openshift/cluster-monitoring-operator/pull/224/files#diff-65c82dcf1aded6541c884411379b2e0c
https://github.com/openshift/cluster-monitoring-operator/pull/224/files#diff-1dca87d186c04a487d72e52ab0b4dde5
/cc @brancz @mxinden @squat