Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3699: chore: merge OmitFromDoc with HideFromDoc introduced in https://github.com/https://github.com/openshift/cluster-monitoring-operator/pull/2210 to hide fields from the doc #2247

Merged
merged 1 commit into from Feb 2, 2024

Conversation

machine424
Copy link
Contributor

…b.com//pull/2210 to hide fields from the doc

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@machine424
Copy link
Contributor Author

Where could we doc this to avoid a recurrence?

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@simonpasquier
Copy link
Contributor

/lgtm

Where could we doc this to avoid a recurrence?

It's already in the documentation (https://github.com/openshift/cluster-monitoring-operator/tree/master/hack/docgen#ignoring-fields-from-the-doc) but I suppose that we don't have enough exposure with the tooling to remember it.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [machine424,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machine424
Copy link
Contributor Author

machine424 commented Feb 1, 2024

It's already in the documentation (https://github.com/openshift/cluster-monitoring-operator/tree/master/hack/docgen#ignoring-fields-from-the-doc) but I suppose that we don't have enough exposure with the tooling to remember it.

Indeed, I'll need to open my eyes next time :)

/retitle MON-3699: chore: merge OmitFromDoc with HideFromDoc introduced in #2210 to hide fields from the doc

@openshift-ci openshift-ci bot changed the title chore: merge OmitFromDoc with HideFromDoc introduced in https://githu… MON-3699: chore: merge OmitFromDoc with HideFromDoc introduced in https://github.com/https://github.com/openshift/cluster-monitoring-operator/pull/2210 to hide fields from the doc Feb 1, 2024
@machine424
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 1, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 1, 2024

@machine424: This pull request references MON-3699 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1bbf0f0 and 2 for PR HEAD 30bd30c in total

@simonpasquier
Copy link
Contributor

/retest-required

Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9e3c39a into openshift:master Feb 2, 2024
17 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202402021641.p0.g9e3c39a.assembly.stream for distgit cluster-monitoring-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants