MON-3380: re-add kube-rbac-proxy for /metrics and /federate #2261
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@simonpasquier: This pull request references MON-3380 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
approved
simonpasquier
force-pushed
the
MON-3380-metrics
branch
from
0d21efa
to
7c1f2f8
Compare
Until brancz/kube-rbac-proxy#146 is implemented, we need a dedicated kube-rbac-proxy for static authz. Otherwise it will always do a SubjectAccessReview for requests authenticated using bearer tokens. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
MON-3380-metrics
branch
from
7c1f2f8
to
78fe72a
Compare
|
/skip |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@simonpasquier: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
| @@ -424,11 +422,6 @@ function(params) | |||
| mountPath: '/etc/tls/private', | |||
| name: 'secret-' + prometheusTLSSecret, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I assume no need for tls client here as it'd be done by the rbac proxy?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202402152340.p0.g1878d82.assembly.stream.el9 for distgit cluster-monitoring-operator. |
Until brancz/kube-rbac-proxy#146 is implemented, we need a dedicated kube-rbac-proxy for static authz. Otherwise it will always do a SubjectAccessReview for requests authenticated using bearer tokens.