Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31920: go.mod: bump openshift/api #2290

Merged
merged 1 commit into from Apr 9, 2024

Conversation

jan--f
Copy link
Contributor

@jan--f jan--f commented Mar 20, 2024

Changes in openshift/api now require us to
`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Changes in openshift/api now require us to
`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests"
in order to get the generated CRD manifests in vendor/.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@jan--f
Copy link
Contributor Author

jan--f commented Mar 20, 2024

I came across this on other business and thought we might as well get ahead of things.
I'm mostly wondering about the import location. Not sure if adding this to the main package has any unintended consequences.

@jan--f
Copy link
Contributor Author

jan--f commented Mar 20, 2024

/cc @simonpasquier

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rexagod
Copy link
Member

rexagod commented Apr 9, 2024

/retest

@openshift-ci openshift-ci bot changed the title go.mod: bump openshift/api :OCPBUGS-31920: go.mod: bump openshift/api Apr 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2024
@openshift-ci-robot
Copy link
Contributor

@jan--f: This pull request references Jira Issue OCPBUGS-31920, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Changes in openshift/api now require us to
`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jan--f
Copy link
Contributor Author

jan--f commented Apr 9, 2024

/retitle CPBUGS-31920: go.mod: bump openshift/api

@openshift-ci openshift-ci bot changed the title :OCPBUGS-31920: go.mod: bump openshift/api CPBUGS-31920: go.mod: bump openshift/api Apr 9, 2024
@openshift-ci-robot
Copy link
Contributor

@jan--f: No Jira issue with key CPBUGS-31920 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Changes in openshift/api now require us to
`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2024
@openshift-ci-robot
Copy link
Contributor

@jan--f: The referenced Jira(s) [CPBUGS-31920] could not be located, all automatically applied jira labels will be removed.

In response to this:

Changes in openshift/api now require us to
`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 9, 2024
@jan--f
Copy link
Contributor Author

jan--f commented Apr 9, 2024

/retitle OCPBUGS-31920: go.mod: bump openshift/api

@openshift-ci openshift-ci bot changed the title CPBUGS-31920: go.mod: bump openshift/api OCPBUGS-31920: go.mod: bump openshift/api Apr 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2024
@openshift-ci-robot
Copy link
Contributor

@jan--f: This pull request references Jira Issue OCPBUGS-31920, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Changes in openshift/api now require us to
`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jan--f
Copy link
Contributor Author

jan--f commented Apr 9, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 9, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 9, 2024
@openshift-ci-robot
Copy link
Contributor

@jan--f: This pull request references Jira Issue OCPBUGS-31920, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from juzhao April 9, 2024 12:14
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

@jan--f: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node d8cef7f link false /test e2e-aws-ovn-single-node
ci/prow/versions d8cef7f link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bf04aae into openshift:master Apr 9, 2024
15 of 17 checks passed
@openshift-ci-robot
Copy link
Contributor

@jan--f: Jira Issue OCPBUGS-31920: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31920 has been moved to the MODIFIED state.

In response to this:

Changes in openshift/api now require us to
`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202404100642.p0.gbf04aae.assembly.stream.el9 for distgit cluster-monitoring-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants