New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-31920: go.mod: bump openshift/api #2290
OCPBUGS-31920: go.mod: bump openshift/api #2290
Conversation
Changes in openshift/api now require us to `import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
I came across this on other business and thought we might as well get ahead of things. |
/cc @simonpasquier |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@jan--f: This pull request references Jira Issue OCPBUGS-31920, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retitle CPBUGS-31920: go.mod: bump openshift/api |
@jan--f: No Jira issue with key CPBUGS-31920 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jan--f: The referenced Jira(s) [CPBUGS-31920] could not be located, all automatically applied jira labels will be removed. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retitle OCPBUGS-31920: go.mod: bump openshift/api |
@jan--f: This pull request references Jira Issue OCPBUGS-31920, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@jan--f: This pull request references Jira Issue OCPBUGS-31920, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jan--f: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
bf04aae
into
openshift:master
@jan--f: Jira Issue OCPBUGS-31920: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31920 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202404100642.p0.gbf04aae.assembly.stream.el9 for distgit cluster-monitoring-operator. |
Changes in openshift/api now require us to
`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/.