OCPBUGS-28650: fix generation of telemeter token hash #2298
Conversation
simonpasquier
commented
Apr 8, 2024
simonpasquier
commented
- I added CHANGELOG entry for this change.
- No user facing changes, so no entry in CHANGELOG was needed.
openshift-ci-robot
added
jira/severity-important
|
@simonpasquier: This pull request references Jira Issue OCPBUGS-28650, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/skip |
It also changes the hash algorithm from sha256 to fnv to be consistent with the rest of code and to signal that the use of the function is non-cryptographic. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
OCPBUGS-28650
branch
from
7f18445
to
ca471c9
Compare
|
/lgtm |
There was a problem hiding this comment.
IIUC even though we could strconv.ParseUint(<telemeter-token-hash>, 32, 64) to get back the generated hash (h.Sum64()), that shouldn't matter as it'd be different from the actual token hash in pull-secret since the hashing algorithm being used here is different.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, rexagod, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-agnostic-operator |
|
@simonpasquier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit d7252f8
into
openshift:master
|
@simonpasquier: Jira Issue OCPBUGS-28650: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-28650 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.15 |
|
/cherrypick release-4.15 |
|
@simonpasquier: new pull request created: #2303 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@simonpasquier: new pull request could not be created: failed to create pull request against openshift/cluster-monitoring-operator#release-4.15 from head openshift-cherrypick-robot:cherry-pick-2298-to-release-4.15: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-2298-to-release-4.15."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
