Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg,jsonnet: scrape master kubelets #256

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

squat
Copy link
Contributor

@squat squat commented Feb 19, 2019

Now that openshift/cluster-kube-apiserver-operator#247
has landed, we can scrape kubelets on both master AND worker nodes. This
commit renames references from "csr-controller-ca" to "kubelet-serving-ca"
as this bundle contains the correct CA certs fo both worker and master
kubelets.

xref: #250

Now that openshift/cluster-kube-apiserver-operator#247
has landed, we can scrape kubelets on both master AND worker nodes. This
commit renames references from "csr-controller-ca" to "kubelet-serving-ca"
as this bundle contains the correct CA certs fo both worker and master
kubelets.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2019
Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants