Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/manifests: Update etcd namespace #336

Merged
merged 1 commit into from Apr 26, 2019
Merged

pkg/manifests: Update etcd namespace #336

merged 1 commit into from Apr 26, 2019

Conversation

brancz
Copy link
Contributor

@brancz brancz commented Apr 24, 2019

I haven't actually found the pull request that changed this, but looking at new clusters, this seems to be where etcd lives.

@s-urbaniak @squat @metalmatze @mxinden @paulfantom

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2019
squat
squat approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@brancz
Copy link
Contributor Author

brancz commented Apr 24, 2019

/retest

@s-urbaniak
Copy link
Contributor

I think we have to look further :-( According to CI

	prometheus_client.go:181: failed to extract first value from query response for query "max(up{job=\"etcd\"})": expected body to contain single timeseries but got 0

@deads2k
Copy link
Contributor

deads2k commented Apr 24, 2019

I was about to make this change (just found it). It happened here openshift/machine-config-operator#648 .

Be aware that certs are moving too openshift/installer#1666

@brancz brancz mentioned this pull request Apr 24, 2019
Merged
@wking
Copy link
Member

wking commented Apr 24, 2019

/hold

Sounds like this needs adjustments before it can get through CI? I'm dropping a hold so the restest-bot doesn't pound away at this overnight (although it's been quiet so far). Pull the hold whenever (maybe I'm misunderstanding the earlier comment).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
@s-urbaniak
Copy link
Contributor

/hold cancel

just a quick confirmation point that the etcd target is now up with this PR:
image

The CI failure must have had stale payloads I guess.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2019
@s-urbaniak
Copy link
Contributor

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2019
@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, s-urbaniak, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brancz,s-urbaniak,squat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brancz
Copy link
Contributor Author

brancz commented Apr 25, 2019

/retest

2 similar comments
@paulfantom
Copy link
Contributor

/retest

@brancz
Copy link
Contributor Author

brancz commented Apr 25, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@brancz
Copy link
Contributor Author

brancz commented Apr 26, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@brancz
Copy link
Contributor Author

brancz commented Apr 26, 2019

/retest

1 similar comment
@brancz
Copy link
Contributor Author

brancz commented Apr 26, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@brancz
Copy link
Contributor Author

brancz commented Apr 26, 2019

/retest

2 similar comments
@brancz
Copy link
Contributor Author

brancz commented Apr 26, 2019

/retest

@brancz
Copy link
Contributor Author

brancz commented Apr 26, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit cef3220 into openshift:master Apr 26, 2019
@brancz brancz deleted the update-etcd-ns branch April 27, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@elad661 elad661 Awaiting requested review from elad661

@mxinden mxinden Awaiting requested review from mxinden

Assignees

@s-urbaniak s-urbaniak

@squat squat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@brancz @s-urbaniak @deads2k @wking @openshift-ci-robot @paulfantom @openshift-bot @squat @openshift-merge-robot