New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move alertmanager-proxy port to 9095 #411
Conversation
We need to free port 9094 as we are moving alertmanager mesh to this port from 6783
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Would it be possible to instead of changing the port to just bind against the pod ip? Alertmanager binds against localhost iirc. I feel that would be a less breaking and less unexpected setup. |
ping @paulfantom can you comment on #411 (comment)? |
For context, we've had bugs opened for similar changes, and this one is rather extreme, as if someone integrated with the alertmanager endpoints (which we actively encourage), then we've just broken their alerting pipeline. |
We can roll it back and even provide backwards compatibility by forcing alertmanager to advertise gossip not on port 9094 but on 6783 by using I didn't want to have two different things on port with the same number as this might be confusing. |
Needed to merge openshift/prometheus-operator#35 as we need to move alertmanager-proxy to not be on port 9094.
/cc @brancz @lilic @s-urbaniak