[MON-808] add ignoreNamespaceSelectors field #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
/lgtm |
openshift-ci-robot
added
lgtm
Prevents service and pod monitors from selecting namespaces other than their own.
pgier
force-pushed
the
ignore-namespace-selectors
branch
from
344e33f
to
4a4a91d
Compare
|
rebased to fix bindata conflict |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pgier, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
nit: Could we not include manually changed and generated stuff in the same commit, but split them into 2? |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@paulfantom yeah, that makes sense, it would make the actual changes more clear and easier to rebase. I'll do that in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents service and pod monitors from selecting namespaces other than
their own.