Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1774621: telemeter: bump dependencies #563

Merged
merged 1 commit into from Nov 22, 2019
Merged

Bug 1774621: telemeter: bump dependencies #563

merged 1 commit into from Nov 22, 2019
+19 −17

Conversation

s-urbaniak
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 22, 2019
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Bugzilla bug 1774621, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1774621: telemeter: bump dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2019
@s-urbaniak s-urbaniak mentioned this pull request Nov 22, 2019
Closed
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2019
@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2019
@paulfantom
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, s-urbaniak, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [paulfantom,s-urbaniak,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@paulfantom
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@awgreene
Copy link
Contributor

@s-urbaniak Thanks for closing #561.

Will this be backported to the 4.3 branch?

@s-urbaniak
Copy link
Contributor Author

@awgreene my understanding is that this should still land in 4.3 once green, cc @bparees for confirmation

@awgreene
Copy link
Contributor

@awgreene my understanding is that this should still land in 4.3 once green, cc @bparees for confirmation

@s-urbaniak I believe that changed as of 9am EST this morning.

@bparees
Copy link
Contributor

bparees commented Nov 22, 2019

@awgreene my understanding is that this should still land in 4.3 once green, cc @bparees for confirmation

yeah since the branch happened this morning, this will only land in 4.4(master) currently. You will need a second BZ targeting 4.3 and have to cherry-pick this to release-4.3.

The 4.4 BZ will need to be in "modified" (not verified) to get the cherry-pick approved.

@openshift-merge-robot openshift-merge-robot merged commit 1675f81 into openshift:master Nov 22, 2019
@s-urbaniak s-urbaniak deleted the bump-telemeter branch November 26, 2019 15:35
@s-urbaniak
Copy link
Contributor Author

/cherry-pick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 26, 2019
Merged
@openshift-cherrypick-robot
Copy link

@s-urbaniak: new pull request created: #570

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgreene awgreene Awaiting requested review from awgreene

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@simonpasquier simonpasquier

@paulfantom paulfantom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@s-urbaniak @openshift-ci-robot @simonpasquier @paulfantom @openshift-bot @awgreene @bparees @openshift-cherrypick-robot @openshift-merge-robot