Revert 586 revertremotewrite #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XL
brancz
force-pushed
the
revert-586-revertremotewrite
branch
3 times, most recently
from
b0e9136
to
8e06837
Compare
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
|
unhold at will once ready 👍 |
|
/retest |
7 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
brancz
force-pushed
the
revert-586-revertremotewrite
branch
from
8e06837
to
17c5685
Compare
|
/lgtm /hold free feel to cancel the hold when ready to be merged |
brancz
force-pushed
the
revert-586-revertremotewrite
branch
from
17c5685
to
de77b5d
Compare
The previous configuration had very high concurrency at a small batch size, this change reverses this, and has a large batch at lower concurrency and also increased the backoff times for retries as well as decreased the overall of retries attempted (from up to 50 retries to 5).
brancz
force-pushed
the
revert-586-revertremotewrite
branch
from
de77b5d
to
4217e40
Compare
|
/retest |
|
/hold cancel /lgtm |
openshift-ci-robot
added
lgtm
|
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, LiliC, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at using remote write for OpenShift telemetry, now that the backend has authz caching and this PR additionally reduces concurrency by 50x while increasing batch size.
cc @squat @metalmatze @s-urbaniak @lilic @simonpasquier @pgier @paulfantom @kakkoyun