assets,pkg: Update dependencies #605
Conversation
openshift-ci-robot
added
the
size/L
| @@ -148,44 +148,44 @@ items: | |||
| { | |||
| "columns": [ | |||
| { | |||
| "text": "", | |||
There was a problem hiding this comment.
Not sure about the grafana dashboards changes? 🤔
| @@ -63,7 +63,7 @@ spec: | |||
| - --port=8081 | |||
| - --telemetry-host=127.0.0.1 | |||
| - --telemetry-port=8082 | |||
| image: quay.io/coreos/kube-state-metrics:v1.8.0 | |||
| image: quay.io/coreos/kube-state-metrics:v1.9.0 | |||
There was a problem hiding this comment.
This is fine, we don't want 1.9.0 yet, as it still has a potential bug, but it will be overriden by CVO anyways, so "this is fine". :)
|
cc @openshift/openshift-team-monitoring PTAL, thanks! |
openshift-ci-robot
added
the
approved
|
/test e2e-aws-operator |
| namespaces: | ||
| - monitoring | ||
| topologyKey: kubernetes.io/hostname | ||
| weight: 100 |
There was a problem hiding this comment.
oh I guess this is a good thing to bring in 👍
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold will look at the failures, although from what i could tell they said marketplace failing |
openshift-ci-robot
added
the
do-not-merge/hold
| values: | ||
| - thanos-querier | ||
| namespaces: | ||
| - monitoring |
There was a problem hiding this comment.
I think this namespace needs to be changed @s-urbaniak I will remove this change from this PR, as I don't have the background behind the change. s
There was a problem hiding this comment.
Nvm it comes from kube-prometheus :D
There was a problem hiding this comment.
hmm .. the more i think about this the more i come to the conclusion that we will have to dependency-inject openshift-monitoring and openshift-user-workload-monitoring during runtime.
|
@s-urbaniak the file in question came in through prometheus-operator not kube-promethus, so I left it out, we can do that another time in a separate PR. Probably after the release of prometheus-operator. PTAL, thanks! |
openshift-ci-robot
removed
the
size/L
openshift-ci-robot
added
the
size/XXL
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| scheme: https | ||
| tlsConfig: | ||
| caFile: /etc/prometheus/configmaps/kubelet-serving-ca-bundle/ca-bundle.crt | ||
| insecureSkipVerify: false |
There was a problem hiding this comment.
is this now left out by purpose?
There was a problem hiding this comment.
It's github being silly, it just moved to the end of the file, because we needed to apply the relabelling to the other endpoint.
| - admissionregistration.k8s.io | ||
| resources: | ||
| - mutatingwebhookconfigurations | ||
| - validatingwebhookconfigurations |
There was a problem hiding this comment.
out of curiosity: do we also need those permissions inherited?
There was a problem hiding this comment.
These are new metrics based on those resources added to kube-state-metrics. We are in the process of switching to this version of ksm yes.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, LiliC, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This primarily brings in changes from prometheus-operator/kube-prometheus#365 but also bumps other dependencies.