Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1751706: Removing KubeVersionMismatch alert #611

Merged

Conversation

paulfantom
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2020
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiliC, paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@s-urbaniak
Copy link
Contributor

let's just verify by @deads2k and @mfojtik that this is the wanted way to go.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020
@lilic
Copy link
Contributor

lilic commented Jan 14, 2020

Judging by this bugzilla they want that. :) https://bugzilla.redhat.com/show_bug.cgi?id=1751706

@mfojtik
Copy link
Member

mfojtik commented Jan 14, 2020

Yes, this alert does not have much sense as having different levels of Kubernetes components running is supported scenario.

@s-urbaniak s-urbaniak changed the title Removing KubeVersionMismatch alert Bug 1751706: Removing KubeVersionMismatch alert Jan 14, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 14, 2020
@openshift-ci-robot
Copy link
Contributor

@paulfantom: This pull request references Bugzilla bug 1751706, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1751706: Removing KubeVersionMismatch alert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Contributor

/test e2e-aws-operator

@s-urbaniak
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9e71806 into openshift:master Jan 14, 2020
@openshift-ci-robot
Copy link
Contributor

@paulfantom: All pull requests linked via external trackers have merged. Bugzilla bug 1751706 has been moved to the MODIFIED state.

In response to this:

Bug 1751706: Removing KubeVersionMismatch alert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants