A/B flag for remote write #617
Conversation
This adds a flag to enable/disable the remote write feature instead of merging large pieces of code. By default the remote write feature is turned off. This allows us to still make use of the new configuration mechanism that was introduced by it that makes adding new telemetry data much easier than before.
openshift-ci-robot
added
the
size/XL
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Just to check in CI that indeed the v1 protocol is used. |
openshift-ci-robot
added
the
do-not-merge/hold
|
Validated that this works as expected. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/test e2e-aws-upgrade |
| @@ -86,10 +91,35 @@ func Main() int { | |||
| kubeconfigPath := flagset.String("kubeconfig", "", "The path to the kubeconfig to connect to the apiserver with.") | |||
| apiserver := flagset.String("apiserver", "", "The address of the apiserver to talk to.") | |||
| releaseVersion := flagset.String("release-version", "", "Currently targeted release version to be reconciled against.") | |||
| telemetryConfigFile := flagset.String("telemetry-config", "/etc/cluster-monitoring-operator/telemetry/metrics.yaml", "Path to telemetry-config.") | |||
| remoteWrite := flagset.Bool("enabled-remote-write", false, "Wether to use legacy telemetry write protocol or Prometheus remote write.") | |||
There was a problem hiding this comment.
So this is the real change now, is it?
|
@brancz don't forget to update the docs :) |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This implements the remote write feature, but turns it off by default, but at the same time allows using the new, much simpler configuration mechanism for selecting metrics while using the more conservative v1 protocol.
@lilic @s-urbaniak