Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1803192: *: duplicate shared configmap in openshift-config-managed namespace #654

Merged
merged 1 commit into from Feb 17, 2020
Merged

Bug 1803192: *: duplicate shared configmap in openshift-config-managed namespace #654

merged 1 commit into from Feb 17, 2020

Conversation

simonpasquier
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2020
@s-urbaniak
Copy link
Contributor

one mini-nit, else lgtm, thank you!

@simonpasquier simonpasquier force-pushed the use-dedicated-ns-for-sharing-config branch from 9819e6d to 8a3ea5d Compare February 17, 2020 09:17
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2020
@s-urbaniak
Copy link
Contributor

side note: i believe we need to set up a role binding against the openshift-config-managed namespace in https://github.com/openshift/cluster-monitoring-operator/blob/master/manifests/0000_50_cluster_monitoring_operator_02-role.yaml.

it might be that e2e fails because we have no permission to create a configmap in that namespace.

@simonpasquier
Copy link
Contributor Author

it might be that e2e fails because we have no permission to create a configmap in that namespace.

I wasn't sure. If e2e tests fail because of this, I'll add the required permission for sure.

@simonpasquier
*: duplicate shared configmap in openshift-config-managed namespace
7d0901a 
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier force-pushed the use-dedicated-ns-for-sharing-config branch from 8a3ea5d to 7d0901a Compare February 17, 2020 10:47
@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [s-urbaniak,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@simonpasquier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier simonpasquier changed the title Bugzilla 1803192: *: duplicate shared configmap in openshift-config-managed namespace Bug 1803192: *: duplicate shared configmap in openshift-config-managed namespace Feb 17, 2020
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: This pull request references Bugzilla bug 1803192, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1803192: *: duplicate shared configmap in openshift-config-managed namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3894ebc into openshift:master Feb 17, 2020
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: All pull requests linked via external trackers have merged. Bugzilla bug 1803192 has been moved to the MODIFIED state.

In response to this:

Bug 1803192: *: duplicate shared configmap in openshift-config-managed namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier simonpasquier deleted the use-dedicated-ns-for-sharing-config branch February 17, 2020 13:44
@simonpasquier simonpasquier mentioned this pull request Feb 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak s-urbaniak left review comments

@pgier pgier Awaiting requested review from pgier

Assignees

@s-urbaniak s-urbaniak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonpasquier @s-urbaniak @openshift-ci-robot @openshift-merge-robot