Bug 1794616: pkg/manifests: set modified telemeter-client command line arguments

[s-urbaniak]

Currently we are manipulating but not changing them. This fixes it.
The current symptom is that the new metrics configuration scheme
is effectively not enabled.

/cc @openshift/openshift-team-monitoring

[openshift-ci-robot]

@s-urbaniak: This pull request references Bugzilla bug 1794616, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1794616: pkg/manifests: set modified telemeter-client command line arguments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lilic]

/lgtm

Should we add a test in the future to make sure that the deployment is as expected?

[s-urbaniak]

/test e2e-aws-operator

[simonpasquier]

/lgtm

any way we can verify that telemeter client is functioning properly? (I haven't checked the e2e tests TBH)

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, s-urbaniak, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lilic,s-urbaniak,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[s-urbaniak]

@lilic yes indeed, I can implement an e2e test that verifies the command line arguments
@simonpasquier hmm ... good idea! maybe via some metric that telemeter-client exposes that it successfully sent metrics. does something like this also exist for prometheus remote-write?

[lilic]

We should yes plan with remote-write in mind, and not invest too much time with the current stack as it will hopefully go away soon.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@s-urbaniak: All pull requests linked via external trackers have merged. Bugzilla bug 1794616 has been moved to the MODIFIED state.

In response to this:

Bug 1794616: pkg/manifests: set modified telemeter-client command line arguments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.