Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1804179: pkg/client: set CreationTimestamp at create time, not only at update time #657

Merged
merged 1 commit into from Feb 18, 2020

Conversation

s-urbaniak
Copy link
Contributor

If the user configures a PVC before Prometheus is created
it fails because of validation errors.

This fixes it.

…time.

If the user configures a PVC before Prometheus is created
it fails because of validation errors.

This fixes it.
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: An error was encountered searching for bug 1801023 on the Bugzilla server at https://bugzilla.redhat.com:

did not get one bug, but 0: {[]}
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1801023: pkg/client: set CreationTimestamp at create time, not only at update time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Contributor Author

/cc @openshift/openshift-team-monitoring-maintainers

@openshift-ci-robot openshift-ci-robot requested a review from a team February 18, 2020 08:23
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 18, 2020
@brancz
Copy link
Contributor

brancz commented Feb 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@s-urbaniak
Copy link
Contributor Author

/bugzilla refresh
/retest

@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: An error was encountered searching for bug 1801023 on the Bugzilla server at https://bugzilla.redhat.com:

did not get one bug, but 0: {[]}
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@s-urbaniak s-urbaniak changed the title Bug 1801023: pkg/client: set CreationTimestamp at create time, not only at update time Bug https://bugzilla.redhat.com/show_bug.cgi?id=1804179: pkg/client: set CreationTimestamp at create time, not only at update time Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug https://bugzilla.redhat.com/show_bug.cgi?id=1804179: pkg/client: set CreationTimestamp at create time, not only at update time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak changed the title Bug https://bugzilla.redhat.com/show_bug.cgi?id=1804179: pkg/client: set CreationTimestamp at create time, not only at update time Bug 1804179: pkg/client: set CreationTimestamp at create time, not only at update time Feb 18, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Bugzilla bug 1804179, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1804179: pkg/client: set CreationTimestamp at create time, not only at update time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Bugzilla bug 1804179, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 328ef8e into openshift:master Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: All pull requests linked via external trackers have merged. Bugzilla bug 1804179 has been moved to the MODIFIED state.

In response to this:

Bug 1804179: pkg/client: set CreationTimestamp at create time, not only at update time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak deleted the bz-1801023 branch February 18, 2020 13:45
juzhao added a commit to juzhao/cluster-monitoring-operator that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants