Bug 1807100: pkg/manifests: rename shared config's keys to include 'Public'

[simonpasquier]

cc @openshift/openshift-team-monitoring @benjaminapetersen

[openshift-ci-robot]

@simonpasquier: This pull request references Bugzilla bug 1807100, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1807100: pkg/manifests: rename shared config's keys to include 'Public'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@simonpasquier: This pull request references Bugzilla bug 1807100, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1807100: pkg/manifests: rename shared config's keys to include 'Public'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[paulfantom]

/lgtm
/hold
putting on hold as I don't know what is the status of the discussions around it.
/cc @s-urbaniak

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [paulfantom,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhadvig]

@paulfantom so the thing is that console consumes those URLs from the shared-config configmap, and since we are consuming variety of different variables and we like to be as explicit about the naming of the keys as possible. We talked about the names over the console PR and we agreed that best would be to already consume configmap with explicit key names.
Logging operator (which shared-config we are consuming as well) is already using this explicit naming in openshift/cluster-logging-operator#374 and now they are backporting to 4.4
ccíng @benjaminapetersen

[s-urbaniak]

let's have a final 🆗 from @bparees on the naming part, then we can un/hold this PR.

[bparees]

@s-urbaniak looks fine to me. I think there's a follow up for @openshift/openshift-team-user-interface to figure out where to document best practices for publishing information like this (whether to do it in a configmap vs a status field of a resource, as well as naming patterns for URLs)

[openshift-bot]

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Bugzilla bug 1807100, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kyoto]

/hold cancel
(per Ben's comment)

[openshift-ci-robot]

@simonpasquier: All pull requests linked via external trackers have merged. Bugzilla bug 1807100 has been moved to the MODIFIED state.

In response to this:

Bug 1807100: pkg/manifests: rename shared config's keys to include 'Public'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[simonpasquier]

/cherry-pick release-4.4

[openshift-cherrypick-robot]

@simonpasquier: new pull request created: #680

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.