Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1812719: address missing resource requests #711

Merged
merged 6 commits into from Mar 20, 2020
Merged

Bug 1812719: address missing resource requests #711

merged 6 commits into from Mar 20, 2020

Conversation

s-urbaniak
Copy link
Contributor

/cc @openshift/openshift-team-monitoring

@openshift-ci-robot openshift-ci-robot requested a review from a team March 18, 2020 15:16
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 18, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Bugzilla bug 1812719, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1812719: address missing resource requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@lilic
Copy link
Contributor

lilic commented Mar 18, 2020

/retest

@s-urbaniak
Copy link
Contributor Author 

level=error msg="Cluster operator monitoring Degraded is True with UpdatingAlertmanagerFailed: Failed to rollout the stack. Error: running task Updating Alertmanager failed: waiting for Alertmanager object changes failed: waiting for Alertmanager: expected 3 replicas, updated 0 and available 0"

this looks somehow consistent, will have a look.

@s-urbaniak
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
@s-urbaniak
Copy link
Contributor Author

/retest
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2020
@s-urbaniak
Copy link
Contributor Author

/retest

@s-urbaniak
Copy link
Contributor Author

s-urbaniak commented Mar 20, 2020 •
edited

failures seem to be related to user workload monitoring cc @lilic :


=== CONT  TestMultinamespacePrometheusRule
--- FAIL: TestMultinamespacePrometheusRule (40.83s)
    route_client.go:229: unexpected status code response, want 200, got 503

@lilic
Copy link
Contributor

lilic commented Mar 20, 2020

Could be related, I have a WIP PR out already, can't be fixed before that. But seems like tests passed fine now.

@s-urbaniak
Copy link
Contributor Author

/test e2e-aws

1 similar comment
@s-urbaniak
Copy link
Contributor Author

/test e2e-aws

lilic
lilic reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 482bbf7 into openshift:master Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: All pull requests linked via external trackers have merged. Bugzilla bug 1812719 has been moved to the MODIFIED state.

In response to this:

Bug 1812719: address missing resource requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak mentioned this pull request Mar 23, 2020
Merged
This was referenced Apr 14, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic left review comments

Assignees

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@s-urbaniak @openshift-ci-robot @lilic @openshift-bot @openshift-merge-robot