Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1809353: Add infrastructures.config.openshift.io to cluster-monitoring-operator role #716

Merged
merged 1 commit into from Mar 20, 2020
Merged

Bug 1809353: Add infrastructures.config.openshift.io to cluster-monitoring-operator role #716

merged 1 commit into from Mar 20, 2020

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Mar 20, 2020

Follow up to #705
The cluster-monitoring-operator service account needs access to infrastructure resources.

@csrwng csrwng changed the title Add infrastructures.config.openshift.io to cluster-monitoring-operator role Bug 1809353: Add infrastructures.config.openshift.io to cluster-monitoring-operator role Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

@csrwng: This pull request references Bugzilla bug 1809353, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1809353: Add infrastructures.config.openshift.io to cluster-monitoring-operator role

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 20, 2020
@csrwng
Copy link
Contributor Author

csrwng commented Mar 20, 2020

@lilic @s-urbaniak ptal

lilic
lilic reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 20, 2020
@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, lilic, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lilic
Copy link
Contributor

lilic commented Mar 20, 2020

Random failures in CI ranging from

2020/03/20 10:11:24 wait for prometheus-k8s: error executing prometheus query: unexpected status code response, want 200, got 403: timed out waiting for the condition

to actual prow failures.

@openshift-merge-robot openshift-merge-robot merged commit 31fe1d0 into openshift:master Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

@csrwng: All pull requests linked via external trackers have merged. Bugzilla bug 1809353 has been moved to the MODIFIED state.

In response to this:

Bug 1809353: Add infrastructures.config.openshift.io to cluster-monitoring-operator role

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic left review comments

@metalmatze metalmatze Awaiting requested review from metalmatze

Assignees

@s-urbaniak s-urbaniak

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@csrwng @openshift-ci-robot @s-urbaniak @openshift-bot @lilic @openshift-merge-robot