Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update prometheus-operator to v0.38.0 #720

Merged
merged 1 commit into from Mar 24, 2020
Merged

update prometheus-operator to v0.38.0 #720

merged 1 commit into from Mar 24, 2020

Conversation

pgier
Copy link
Contributor

@pgier pgier commented Mar 23, 2020

No description provided.

@pgier pgier mentioned this pull request Mar 23, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
lilic
lilic reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold

and you can unhold both PRs at once, while CI is green? :)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, pgier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2020
@lilic
Copy link
Contributor

lilic commented Mar 23, 2020

/retest

@lilic
Copy link
Contributor

lilic commented Mar 23, 2020

I guess we have to merge prom-operator PR first and then this one. Judging by the failure.

@pgier
Copy link
Contributor Author

pgier commented Mar 23, 2020

/retest

@pgier
Copy link
Contributor Author

pgier commented Mar 24, 2020

Looks like it was a flake, I think the prometheus rule test failure was just a coincidence.

@pgier
Copy link
Contributor Author

pgier commented Mar 24, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6e260e4 into openshift:master Mar 24, 2020
@openshift-ci-robot
Copy link
Contributor

@pgier: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 62251ea link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic left review comments

@paulfantom paulfantom Awaiting requested review from paulfantom

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pgier @openshift-ci-robot @lilic @openshift-merge-robot