OCM: Add OpenShift Cluster Manager team #738
Conversation
|
@cben - please take a look. Does this look like a comprehensive list of the metrics we query in clusters service? |
|
@nimrodshn @zvikorn FYI if you make OCM rely on new metrics it wasn't querying before, we should keep this file updated so telemetry team knows we're consuming them and would talk to us before incompatible changes. |
|
If not urgent, I'll review these next week. |
|
/retest |
Documentation/data-collection.md
Outdated
| @@ -32,20 +32,20 @@ data: | |||
| # to identify when an update causes a service to begin to crash-loop or | |||
| # flake. | |||
| - '{__name__="count:up1"}' | |||
| # cluster_version reports what payload and version the cluster is being | |||
| # (team-OCM) cluster_version reports what payload and version the cluster is being | |||
There was a problem hiding this comment.
Do you have a github openshift handle? so we just ping you on PRs via @team-ocm ?
There was a problem hiding this comment.
I don't - how do I get one?
There was a problem hiding this comment.
We are for example @openshift/openshift-team-monitoring I am guessing there is a mojo page for this? :D Would just make it easier to have folks in one github team to just ping you. Or if you put one person there who is responsible, its up to you.
There was a problem hiding this comment.
I've requested a team be created for OCM. Thanks
There was a problem hiding this comment.
We have a team now: @openshift/openshift-team-cluster-manager
I've updated this patch with the new team handle. Thanks!
vkareh
force-pushed
the
add-team-ocm-to-metrics
branch
from
d2f9e87
to
e239a1e
Compare
openshift-ci-robot
added
the
needs-rebase
vkareh
force-pushed
the
add-team-ocm-to-metrics
branch
from
e239a1e
to
965743b
Compare
The OCM team relies on these queries for reporting metrics to customers and would like to be notified when they change so that the cluster service can adapt.
vkareh
force-pushed
the
add-team-ocm-to-metrics
branch
from
965743b
to
4e0f326
Compare
openshift-ci-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, vkareh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
The OCM team relies on these queries for reporting metrics to customers
and would like to be notified when they change so that the cluster
service can adapt.