Pin dependencies for 4.5 release #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest CI problems |
wking
added a commit
to wking/cluster-monitoring-operator
that referenced
this pull request
Jun 25, 2020
Generated with: $ make jsonnet/vendor # to install jb $ jb --version v0.3.1 $ (cd jsonnet && jb install https://github.com/coreos/etcd/Documentation/etcd-mixin) GET https://github.com/coreos/etcd/archive/2b79442d8e9fc54b1ac27e7e230ac0e4c132a054.tar.gz 200 $ touch jsonnet/jsonnetfile.lock.json # recover from any previous flubbed generation which might have left timestamps in place convincing Make it didn't need to rebuild bindata.go $ make generate-in-docker This pulls in: $ git --no-pager log --oneline f1eca4e1fa5de962ff8079af836bb390e88d1f4c..2b79442d8e9fc54b1ac27e7e230ac0e4c132a054 -- Documentation/etcd-mixin 2c4877064 Documentation/etcd-mixin: Use etcd_mvcc_db_total_size_in_bytes metric 68c5f6066 Documentation/etcd-mixin: Set unique UID for Grafana dashboard 322c38e16 Documentation/etcd-mixin: Fix etcdHighNumberOfLeaderChanges (#11448) The first two of those are [1]. The last is [2], and as the discussion there points out, the rate>3 approach is effectively "never fire" (because we are unlikely to ever have more than three elections per second). Also interesting, is that f1eca4e1fa is in etcd's release-3.4 branch, while I'm pinning the master branch. The current coreos release-3.4 tip is etcd-io/etcd@31e49a4df30, which has no etcd-mixin changes since f1eca4e1fa. My impression is that mixin changes are unlikely to be backported to release branches, and also unlikely to depend on the intricacies of the underlying etcd version, so I'm tracking master instead of release-3.4 in this commit. The move to f1eca4e1fa had landed here via 5c251d9 (jsonnet/jsonnetfile.lock.json: jb update, 2020-04-17, openshift#760). [1]: etcd-io/etcd#11768 [2]: etcd-io/etcd#11448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last step in the release checklist #756
cc @openshift/openshift-team-monitoring PTAL thanks!