Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1821666: thanos ruler secret cleanup #765

Merged
merged 2 commits into from Apr 30, 2020
Merged

Bug 1821666: thanos ruler secret cleanup #765

merged 2 commits into from Apr 30, 2020

Conversation

pgier
Copy link
Contributor

@pgier pgier commented Apr 23, 2020

Fix cleanup of thanos rule grpc tls secret.

@openshift-ci-robot openshift-ci-robot added bugzilla/low bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 23, 2020
@openshift-ci-robot
Copy link
Contributor

@pgier: This pull request references Bugzilla bug 1821666, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1821666: thanos ruler secret cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020
@pgier
Copy link
Contributor Author

pgier commented Apr 23, 2020

@lilic PTAL, the previous PR (#762) was failing to clean up one of the secrets, this seems to fix it in my local testing.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2020
@s-urbaniak
Copy link
Contributor

lgtm module the rebase.

@lilic
Copy link
Contributor

lilic commented Apr 27, 2020 •
edited

While you need to rebase anyways do you mind doing us a favour, in the Makefile we forgot to pin the jsonnet-ci release:
In the Makefile -> https://github.com/openshift/cluster-monitoring-operator/blob/master/Makefile#L30 do you mind adding quay.io/coreos/jsonnet-ci:release-0.38 - pin to the version. This is to avoid needing a bugzilla for master PR, as that is purely for local development anyways. Thanks!

See PR for background: https://github.com/openshift/release/pull/8118/files

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/low labels Apr 29, 2020
@pgier
Bug 1821666: thanos ruler secret cleanup
adf7609 
Fix cleanup of thanos rule grpc tls secret.
@pgier
pin jsonnet-ci build image to specific version
68955dd 
This prevents changes in prometheus-operator master from causing
build failures in this project.
@pgier pgier force-pushed the cleanup-thanos-ruler-resources branch from f7f7ca6 to 68955dd Compare April 29, 2020 16:00
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2020
@pgier
Copy link
Contributor Author

pgier commented Apr 29, 2020

@lilic done, PTAL

lilic
lilic approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, pgier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 80f52d4 into openshift:master Apr 30, 2020
@openshift-ci-robot
Copy link
Contributor

@pgier: An error was encountered searching for bug 1821666 on the Bugzilla server at https://bugzilla.redhat.com:

response code 502 not 200
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1821666: thanos ruler secret cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic approved these changes

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pgier @openshift-ci-robot @s-urbaniak @lilic @openshift-merge-robot