Bug 1846001: Add rhmi_status metric to telemeter - backport 4.5

[david-martin]

backport of #795

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[openshift-ci-robot]

@david-martin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1845873 - Add rhmi_status metric to telemeter - backport 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@david-martin: This pull request references Bugzilla bug 1845873, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead
• expected Bugzilla bug 1845873 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1845873: Add rhmi_status metric to telemeter - backport 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[david-martin]

/bugzilla refresh

[openshift-ci-robot]

@david-martin: This pull request references Bugzilla bug 1845873, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead
• expected Bugzilla bug 1845873 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@david-martin: This pull request references Bugzilla bug 1846001, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead
• expected Bugzilla bug 1846001 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1846001: Add rhmi_status metric to telemeter - backport 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[david-martin]

/bugzilla refresh

[openshift-ci-robot]

@david-martin: This pull request references Bugzilla bug 1846001, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead
• expected Bugzilla bug 1846001 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[david-martin]

/bugzilla refresh

[openshift-ci-robot]

@david-martin: This pull request references Bugzilla bug 1846001, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead
• expected dependent Bugzilla bug 1845873 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is NEW instead
• expected dependent Bugzilla bug 1845873 to target a release in 4.6.0, 4.6.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[david-martin]

/bugzilla refresh

[openshift-ci-robot]

@david-martin: This pull request references Bugzilla bug 1846001, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead
• expected dependent Bugzilla bug 1845873 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[david-martin]

/hold pending rollout of whitelist to saas-telemeter

[david-martin]

/bugzilla refresh

[openshift-ci-robot]

@david-martin: This pull request references Bugzilla bug 1846001, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1845873 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Bugzilla bug 1845873 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[david-martin]

/unhold

[david-martin]

@s-urbaniak Can you help with the necessary approval of this backport?

[david-martin]

/bugzilla refresh

[openshift-ci-robot]

@david-martin: This pull request references Bugzilla bug 1846001, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1845873 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Bugzilla bug 1845873 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[s-urbaniak]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [s-urbaniak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[lilic]

/hold

We are still resolving the discussion around RHMI and the namespace where these metrics come from, so would prefer if that conversation is resolved before we backport this. In case we need to remove it in master.

[david-martin]

the namespace where these metrics come from

@lilic I don't see how this has any impact on the inclusion of the metric in the allow list.
The metric name will be the same no matter which namespace the pod that exposes it runs in.

cc @alanmoran for awareness of this as it affects ocm integration.

[lilic]

@david-martin
The point what it effects is that it is not tested ever, I understood when doing lgtm on the initial PR is that you are using OLM to install this or integrating with openshift directly, hence my questions about if its part of cluster monitoring openshift namespaces. From my perspective it would be better to have this tested against existing telemetry tests (e.g. number of series sent, etc.) same as its done for OLM cc @brancz as telemetry team lead and architect to make final decision for this.

[openshift-ci-robot]

@david-martin: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/generate	f238e78	link	/test generate
ci/prow/e2e-aws	f238e78	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[david-martin]

Thanks for the explanation @lilic.
I understand where you are coming from now.

Can you & @brancz help me figure out what's needed to get this change landed?
I think it would be best to make an incremental change that unblocks downstream, while lining up work to ensure the right gates, testing & processes are put in place for future metrics from any source (not just rhmi)

[brancz]

OLM already sets precedence here, we also didn't allow any OLM metrics that are not part of that test run. I think the same should apply to RHMI.

[david-martin]

OLM already sets precedence here

@brancz Could you share what has been done here in terms of testing, or any other material for what is being asked of layered products?

[lilic]

@david-martin they have tests in origin that are periodic jobs that install all the red hat operators and run a set of our origin monitoring tests against that cluster, notifications for failures of those go to slack so we they are informed of failures. These ensure the limit of series sent is under 500 series per cluster for example. https://github.com/openshift/release/blob/master/ci-operator/jobs/operator-framework/operator-lifecycle-manager/operator-framework-operator-lifecycle-manager-master-periodics.yaml

(Note we run these tests in openshift for all core operators already, this was a solution for optional Red Hat operators installed via OLM. I would suggest to join next weeks telemetry ecosystem call to discuss anything else further with all stakeholders.)

[sdodson]

/bugzilla refresh

[openshift-ci-robot]

@sdodson: This pull request references Bugzilla bug 1846001, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[david-martin]

/hold pending cardinality test for rhmi-operator (tracked in downstream/private issue https://issues.redhat.com/browse/INTLY-9319)

[sdodson]

/bugzilla refresh

[openshift-ci-robot]

@sdodson: This pull request references Bugzilla bug 1846001, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.z) matches configured target release for branch (4.5.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1845873 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1845873 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sdodson]

@lilic Should this still be held, if not it needs a rebase.

[eparis]

please feel free to reopen if this is still relevant (and rebased)