Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump prometheus-operator to 0.40.0 version #850

Merged
merged 7 commits into from Jul 15, 2020
Merged

Bump prometheus-operator to 0.40.0 version #850

merged 7 commits into from Jul 15, 2020

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Jul 14, 2020

I believe this should fix the errors we have been seeing when bumping to 0.40 prometheus-operator, this is due the fact we were using the apiVersion: apiextensions.k8s.io/v1beta1 and this switches to using apiVersion: apiextensions.k8s.io/v1.

cc @openshift/openshift-team-monitoring

  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2020
brancz
brancz approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Only holding this so we merge it during our work-day. Otherwise lgtm.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@lilic
Copy link
Contributor Author

lilic commented Jul 14, 2020

level=error msg="Error: Error launching source instance: InsufficientInstanceCapacity: We currently do not have sufficient m5.xlarge capacity in the Availability Zone you requested (us-east-1b). Our system will be working on provisioning additional capacity. You can currently get m5.xlarge capacity by not specifying an Availability Zone in your request or choosing us-east-1a, us-east-1c, us-east-1d, us-east-1f."

Seems unrelated.

/retest

@lilic
Copy link
Contributor Author

lilic commented Jul 14, 2020

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@lilic
Copy link
Contributor Author

lilic commented Jul 15, 2020

/hold

Debugging locally, seems like there is another permissions missing.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@lilic
Copy link
Contributor Author

lilic commented Jul 15, 2020

Typo, should be fixed now. :)

@lilic lilic mentioned this pull request Jul 15, 2020
Merged
@lilic
Copy link
Contributor Author

lilic commented Jul 15, 2020

--- FAIL: TestAlertmanagerKubeRbacProxy (15.68s)

Was the only failure here. Retesting.

/retest

simonpasquier
simonpasquier reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, lilic, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brancz,lilic,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilic
Copy link
Contributor Author

lilic commented Jul 15, 2020

aws failure was networking and mongodb 🤷‍♀️ related.
/retest

@lilic
Copy link
Contributor Author

lilic commented Jul 15, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lilic
Copy link
Contributor Author

lilic commented Jul 15, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lilic
Copy link
Contributor Author

lilic commented Jul 15, 2020

level=error msg="Error: Error launching source instance: InsufficientInstanceCapacity: We currently do not have sufficient m5.xlarge capacity in the Availability Zone you requested (us-east-1b). Our system will be working on provisioning additional capacity. You can currently get m5.xlarge capacity by not specifying an Availability Zone in your request or choosing us-east-1a, us-east-1c, us-east-1d, us-east-1f."

Hit the aws InsufficientInstanceCapacity again...

/retest

@lilic
Copy link
Contributor Author

lilic commented Jul 15, 2020

level=error
level=error msg="Error: Error launching source instance: InvalidNetworkInterface.InUse: Interface: [eni-00965ccfba58473bb] in use."
level=error msg="\tstatus code: 400, request id: ac8356bb-1ff3-4c51-99b3-39f45bd4ba78"
level=error
level=error msg=" on ../tmp/openshift-install-174798424/master/main.tf line 124, in resource "aws_instance" "master":"
level=error msg=" 124: resource "aws_instance" "master" {"
level=error
level=error

wow no luck today...
/retest

@lilic
Copy link
Contributor Author

lilic commented Jul 15, 2020

/retest

TestAlertmanagerKubeRbacProxy again it seems...

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 061ba1c into openshift:master Jul 15, 2020
@lilic lilic deleted the fix-crd-version branch July 16, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@brancz brancz brancz approved these changes

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@simonpasquier simonpasquier

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lilic @simonpasquier @openshift-ci-robot @openshift-bot @brancz @openshift-merge-robot