-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump client-go and other deps to v1.18.3 #851
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,34 +4,33 @@ go 1.13 | |
|
||
require ( | ||
github.com/Jeffail/gabs v1.1.1 | ||
github.com/coreos/prometheus-operator v0.38.1 | ||
github.com/coreos/prometheus-operator v0.40.0 | ||
github.com/ghodss/yaml v1.0.0 | ||
github.com/gogo/protobuf v1.3.1 | ||
github.com/imdario/mergo v0.3.6 // indirect | ||
github.com/kylelemons/godebug v1.1.0 // indirect | ||
github.com/mitchellh/hashstructure v1.0.0 // indirect | ||
github.com/openshift/api v0.0.0-20200116145750-0e2ff1e215dd | ||
github.com/openshift/client-go v0.0.0-20200116152001-92a2713fa240 | ||
github.com/openshift/api v0.0.0-20200623075207-eb651a5bb0ad | ||
github.com/openshift/client-go v0.0.0-20200623090625-83993cebb5ae | ||
github.com/openshift/library-go v0.0.0-20200120084036-bb27e57e2f2b | ||
github.com/pkg/errors v0.8.1 | ||
github.com/prometheus/client_golang v1.2.1 | ||
github.com/prometheus/prometheus v2.9.2+incompatible | ||
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e | ||
k8s.io/api v0.17.3 | ||
k8s.io/apiextensions-apiserver v0.17.3 | ||
k8s.io/apimachinery v0.17.3 | ||
k8s.io/apiserver v0.17.3 | ||
github.com/pkg/errors v0.9.1 | ||
github.com/prometheus/client_golang v1.6.0 | ||
github.com/prometheus/prometheus v1.8.2-0.20200609102542-5d7e3e970602 // v1.8.2 is misleading as Prometheus does not have v2 module. This is pointing to v2.19.0, the same as in promehteus- operator v0.40.0 | ||
golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a | ||
k8s.io/api v0.18.4 | ||
k8s.io/apiextensions-apiserver v0.18.3 | ||
k8s.io/apimachinery v0.18.4 | ||
k8s.io/apiserver v0.18.3 | ||
k8s.io/client-go v12.0.0+incompatible | ||
k8s.io/klog v1.0.0 | ||
k8s.io/kube-aggregator v0.17.1 | ||
k8s.io/metrics v0.0.0-20191014074242-8b0351268f72 | ||
k8s.io/kube-aggregator v0.18.3 | ||
k8s.io/metrics v0.18.4 | ||
) | ||
|
||
replace ( | ||
github.com/prometheus/prometheus => github.com/prometheus/prometheus v1.8.2-0.20190819201610-48b2c9c8eae2 // v1.8.2 is misleading as Prometheus does not have v2 module. This is pointing to one commit after 2.12.0. | ||
k8s.io/api => k8s.io/api v0.17.1 | ||
k8s.io/apimachinery => k8s.io/apimachinery v0.17.1 | ||
k8s.io/client-go => k8s.io/client-go v0.17.1 | ||
k8s.io/api => k8s.io/api v0.18.3 | ||
k8s.io/apimachinery => k8s.io/apimachinery v0.18.3 | ||
k8s.io/client-go => k8s.io/client-go v0.18.3 | ||
Comment on lines
+31
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we really need these replacements? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those are ensuring we are pinning to 0.18.3, without them There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
k8s.io/code-generator => k8s.io/code-generator v0.0.0-20190912054826-cd179ad6a269 | ||
k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30 | ||
) |
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do go 1.14 here above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have any features in CMO which need 1.14 and codebase can be compiled with 1.13, so the current setting seems good to me.