pkg/manifests: Allow users to configure EnforcedSampleLimit for user #865
Conversation
lilic
commented
Jul 20, 2020
•
lilic
commented
- I added CHANGELOG entry for this change.
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
This also needs bump of prometheus operator dep, which another PR introduces, hence the failed tests. |
lilic
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@openshift/openshift-team-monitoring ready for review! I tested this on a cluster and checked the limit was applied to the scrape config, but will be a bit harder to add an e2e test for this as the data ends up in a Secret gzipped. Side note tests passed on first try :O 🎉 |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| @@ -1441,6 +1441,10 @@ func (f *Factory) PrometheusUserWorkload(grpcTLS *v1.Secret) (*monv1.Prometheus, | |||
| p.Spec.RemoteWrite = f.config.UserWorkloadConfiguration.Prometheus.RemoteWrite | |||
| } | |||
|
|
|||
| if f.config.UserWorkloadConfiguration.Prometheus.EnforcedSampleLimit != nil { | |||
There was a problem hiding this comment.
This is a new configuration field so we do not want to add this to the old ConfigMap as a way to encourage users to migrate away from the old configmap as it will be deprecated in 4.7.
There was a problem hiding this comment.
precisely why having separate structs for configs is a really good idea 👍 💯
very nice!
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, lilic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
