Bug 1852846: pkg/manifests/manifests.go: Set logLevel for prometheus Operator #875
Conversation
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@lilic: This pull request references Bugzilla bug 1852846, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
do-not-merge/hold
|
Done @simonpasquier PTAL, thanks! |
|
/retest |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
@simonpasquier PTAL, addressed the comments and rebased. Thanks! |
|
/retest |
|
Should we have a test case for this? |
|
@paulfantom how would you propose we test it, we would need to look and parse args from deployments? Note we do not have any other tests for args settings that I am aware of. |
|
I am fine with merging this now, hence: /lgtm I don't have a solution for it now. However since we already had a regression of features due to some other work, I think it would be good to have a tech-debt ticket investigating how we can test such cases. WDYT? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, paulfantom, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sounds good to me! I think we should think of adding tests for all the Configurations we support, existing and new ones, will open ticket for this. |
|
/hold cancel 🤦♀️ |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@lilic: All pull requests linked via external trackers have merged: openshift/cluster-monitoring-operator#875. Bugzilla bug 1852846 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This setting got lost in the large user workload monitoring ConfigMap PR changes, so this fixes the already existing field.
cc @openshift/openshift-team-monitoring