New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1854479: enforce permissions on Thanos querier endpoints #908
Bug 1854479: enforce permissions on Thanos querier endpoints #908
Conversation
@simonpasquier: This pull request references Bugzilla bug 1854479, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
} | ||
|
||
if resp.StatusCode/100 == 2 { | ||
return fmt.Errorf("unexpected status code response, got %d (%s)", resp.StatusCode, framework.ClampMax(b)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we be a bit more explicit about what we expect? i.e. expected request to be rejected, but got status code response %d (%s)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
For multi-tenancy, Thanos querier is protected by 2 kube-rbac-proxy instances: one for queries and the other one for rules. To make sure that a user allowed for queries can't access rules (and the other way around), we configure the proxies for their specific endpoints: * kube-rbac-proxy for PromQL queries allows only the '/api/v1/query' and '/api/v1/query_range' endpoints. * kube-rbac-proxy for rules allows only the '/api/v1/rules' endpoint. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
1ef5492
to
5b74c93
Compare
@simonpasquier: This pull request references Bugzilla bug 1854479, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@simonpasquier: All pull requests linked via external trackers have merged: openshift/kube-rbac-proxy#26, openshift/cluster-monitoring-operator#908. Bugzilla bug 1854479 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This needs openshift/kube-rbac-proxy#26 first