New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1862432: unmask prometheus-adapter service monitor #921
Bug 1862432: unmask prometheus-adapter service monitor #921
Conversation
@dgrisonnet: This pull request references Bugzilla bug 1862432, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
good initial start :+1 you'll have to deploy the service monitor in CMO's reconcile code, right after the deployment of prometheus-adapter: cluster-monitoring-operator/pkg/tasks/prometheusadapter.go Lines 179 to 181 in f4b5b9b
Injecting the server name can be inspired from here: cluster-monitoring-operator/pkg/manifests/manifests.go Lines 1764 to 1774 in 004b497
|
ea13537
to
d7a6d5d
Compare
@s-urbaniak I added the cert and the service monitor reconciliation. PTAL |
one nit, else LGTM 👍 |
Please rebase as we fixed the failing e2e test. |
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
d7a6d5d
to
d7c21b8
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dgrisonnet: All pull requests linked via external trackers have merged: Bugzilla bug 1862432 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @s-urbaniak