Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-jsonnet to faster version #924

Merged
merged 1 commit into from Oct 12, 2020

Conversation

paulfantom
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user-facing changes, so no entry in CHANGELOG was needed.

Pinning to released version of jsonnet doesn't make much sense due to how releases for jsonnet work. More on the topic in prometheus-operator/kube-prometheus#608

This is bringing the same go-jsonnet version as used in kube-prometheus to this repo.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2020
@paulfantom
Copy link
Contributor Author

Since master is now open, can we merge this?

/cc @openshift/openshift-team-monitoring

@openshift-ci-robot openshift-ci-robot requested a review from a team October 12, 2020 11:45
@simonpasquier
Copy link
Contributor

sure!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [paulfantom,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 429c658 into openshift:master Oct 12, 2020
@paulfantom paulfantom deleted the jsonnet branch October 13, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants