Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1887354: Backport fix checking if ClusterRoleBindings need update #956

Merged
merged 5 commits into from Nov 6, 2020
Merged

Bug 1887354: Backport fix checking if ClusterRoleBindings need update #956

merged 5 commits into from Nov 6, 2020

Conversation

paulfantom
Copy link
Contributor

@paulfantom paulfantom commented Oct 12, 2020 •
edited

Backporting following PRs:

Those two should be considered as one fix.

This is not a clean backport due to changed client-go post-4.5 which added the necessity of passing context to Get/Create/...

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Oct 12, 2020
@openshift-ci-robot
Copy link
Contributor

@paulfantom: This pull request references Bugzilla bug 1887354, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

10 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1863011 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1879019 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1879159 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1863011 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • dependent Bugzilla bug 1879019 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • dependent Bugzilla bug 1879159 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

Bug 1887354: Backport fix checking if ClusterRoleBindings need update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 12, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2020
@paulfantom
Copy link
Contributor Author

This has to be based on top of #945. Putting this on hold until dependency PR is merged.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2020
@openshift-ci-robot
Copy link
Contributor

@paulfantom: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-operator 53515c5 link /test e2e-aws-operator
ci/prow/e2e-upgrade 53515c5 link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@s-urbaniak
Copy link
Contributor

@paulfantom #945 seems to be merged 👍

@paulfantom
Copy link
Contributor Author

rebased

@openshift-ci-robot
Copy link
Contributor

@paulfantom: This pull request references Bugzilla bug 1887354, which is valid.

10 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1863011 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1879019 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1879159 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1863011 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • dependent Bugzilla bug 1879019 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • dependent Bugzilla bug 1879159 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

Bug 1887354: Backport fix checking if ClusterRoleBindings need update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom
Copy link
Contributor Author

/retest

@s-urbaniak
Copy link
Contributor

@paulfantom where you able to verify this in a running 4.5 cluster?

@paulfantom
Copy link
Contributor Author

/unhold
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2020
@s-urbaniak
Copy link
Contributor

/lgtm

@s-urbaniak
Copy link
Contributor

as discussed oob the verification was done in 4.6.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [paulfantom,s-urbaniak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees
Copy link
Contributor

bparees commented Oct 23, 2020

#955 is not merged so i don't understand how this was verified on 4.6 already.

@bparees bparees added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Oct 23, 2020
@bparees bparees removed the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Oct 23, 2020
@bparees
Copy link
Contributor

bparees commented Oct 23, 2020

(as such i am holding off tagging it until we have a clear indication of how these changes were vetted in master/4.6 before backporting them)

@s-urbaniak
Copy link
Contributor

@paulfantom ping, can you please elaborate? I believe indeed that the bug was not fully verified in 4.6, hence I am not sure why this is supposed to land in 4.5. I believe we need to land #955 and verify it first before we can proceed here.

@sdodson
Copy link
Member

sdodson commented Oct 28, 2020

/bugzilla refresh
I've added the bug from #955 to the dependencies of the bug this PR is tied to, I expect this to transition to bugzilla/invalid-bug

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 28, 2020
@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Bugzilla bug 1887354, which is invalid:

  • expected dependent Bugzilla bug 1887339 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh
I've added the bug from #955 to the dependencies of the bug this PR is tied to, I expect this to transition to bugzilla/invalid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 28, 2020
@s-urbaniak
Copy link
Contributor

@sdodson indeed, yes, i think it is reasonable to verify #955 first 👍

@s-urbaniak
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 5, 2020
@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: This pull request references Bugzilla bug 1887354, which is valid.

12 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1887339 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1863011 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1879019 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1879159 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1887339 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • dependent Bugzilla bug 1863011 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • dependent Bugzilla bug 1879019 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • dependent Bugzilla bug 1879159 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom
Copy link
Contributor Author

For completion, verification of #955 in 4.6 was done by starting a 4.6 cluster from that PR and working on that.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 5, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7b331f9 into openshift:release-4.5 Nov 6, 2020
@openshift-ci-robot
Copy link
Contributor

@paulfantom: All pull requests linked via external trackers have merged:

Bugzilla bug 1887354 has been moved to the MODIFIED state.

In response to this:

Bug 1887354: Backport fix checking if ClusterRoleBindings need update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic Awaiting requested review from lilic

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@s-urbaniak s-urbaniak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@paulfantom @openshift-ci-robot @s-urbaniak @bparees @sdodson @openshift-bot @openshift-merge-robot