Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admission reviews versions #958

Merged
merged 2 commits into from Nov 4, 2020
Merged

Fix admission reviews versions #958

merged 2 commits into from Nov 4, 2020

Conversation

simonpasquier
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020
paulfantom
paulfantom approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@simonpasquier
Copy link
Contributor Author

/hold

Failing with the same issue as prometheus-operator/prometheus-operator#3574. We need to bump to the future v0.43.0 before being able to merge this :)

level=error msg="Cluster operator monitoring Degraded is True with UpdatingTelemeterclientFailed: Failed to rollout the stack. Error: running task Updating Telemeter client failed: reconciling Telemeter client Prometheus Rule failed: creating PrometheusRule object failed: Internal error occurred: failed calling webhook \"prometheusrules.openshift.io\": expected webhook response of admission.k8s.io/v1, Kind=AdmissionReview, got /, Kind="

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2020
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-operator 5142717 link /test e2e-aws-operator
ci/prow/e2e 5142717 link /test e2e
ci/prow/e2e-upgrade 5142717 link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
jsonnet: Fix admissionReviewVersions in validating webhook
0d2c8a3 
We should only support v1 instead of v1beta1.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
assets,pkg: regenerate
f8d2940
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@simonpasquier
Copy link
Contributor Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020
@simonpasquier
Copy link
Contributor Author

cc @s-urbaniak @paulfantom

@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, s-urbaniak, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [paulfantom,s-urbaniak,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 85df799 into openshift:master Nov 4, 2020
@simonpasquier simonpasquier deleted the fix-admission-reviews-versions branch November 4, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom paulfantom approved these changes

@pgier pgier Awaiting requested review from pgier

Assignees

@s-urbaniak s-urbaniak

@paulfantom paulfantom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@simonpasquier @openshift-bot @openshift-ci-robot @s-urbaniak @paulfantom @openshift-merge-robot