Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch dns resolver to miekgdns #997

Merged
merged 2 commits into from Dec 1, 2020
Merged

Switch dns resolver to miekgdns #997

merged 2 commits into from Dec 1, 2020

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Dec 1, 2020 •
edited

I tested this in my cluster and

cc @openshift/openshift-team-monitoring PTAL, thanks!

  • [] I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@lilic
Copy link
Contributor Author

lilic commented Dec 1, 2020

Screenshot 2020-12-01 at 11 25 28

On my cluster running with these changes, the DNS failure rate went down.

simonpasquier
simonpasquier reviewed Dec 1, 2020
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lilic,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier simonpasquier mentioned this pull request Dec 1, 2020
Merged
2 tasks
@simonpasquier
Copy link
Contributor

Screenshot 2020-12-01 at 11 25 28

On my cluster running with these changes, the DNS failure rate went down.

same here, I went from 100% of DNS failures to 0% with your patch.

@lilic
Copy link
Contributor Author

lilic commented Dec 1, 2020

level=error msg=Error: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.

/retest

@lilic
Copy link
Contributor Author

lilic commented Dec 1, 2020

/retest

@s-urbaniak
Copy link
Contributor

fantastic, very promising results, thank you! 🎉 looking forward to find out what the root cause is with the native Go resolver. 🤞

@lilic
Copy link
Contributor Author

lilic commented Dec 1, 2020

/retest

seems like resource quotas were hit again.

@lilic
Copy link
Contributor Author

lilic commented Dec 1, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lilic
Copy link
Contributor Author

lilic commented Dec 1, 2020

/retest

nothing monitoring related...

@openshift-merge-robot openshift-merge-robot merged commit ad663d0 into openshift:master Dec 1, 2020
@lilic lilic deleted the set-dns-provider branch December 2, 2020 07:54
@kyoto kyoto mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lilic @openshift-ci-robot @simonpasquier @s-urbaniak @openshift-bot @openshift-merge-robot