Bug 1941212: The Multus daemonset should handle 10% maxUnavailable

[openshift-cherrypick-robot]

This is an automated cherry-pick of #992

/assign wking

[openshift-ci-robot]

@openshift-cherrypick-robot: Bugzilla bug 1933159 has been cloned as Bugzilla bug 1941212. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1941212: The Multus daemonset should handle 10% maxUnavailable

In response to this:

[release-4.7] Bug 1933159: The Multus daemonset should handle 10% maxUnavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1941212, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1933159 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1933159 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

[release-4.7] Bug 1941212: The Multus daemonset should handle 10% maxUnavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

We want to take this back to 4.6, because the slow multus DaemonSet is one of the main delays in updating clusters with lots of compute.

/lgtm
/assign @rcarrillocruz

[wking]

No need to keep [release-4.7] in the prefix, because GitHub keeps the target branch as structured info (e.g. search for base:release-4.7).

/retitle Bug 1941212: The Multus daemonset should handle 10% maxUnavailable

[wking]

Backing my earlier comment up with data, here's a ~5h rollout for kube-multus in a 4.5->4.6 update with 257 nodes:

[rcarrillocruz]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rcarrillocruz, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rcarrillocruz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• openshift/cluster-network-operator#1030

Bugzilla bug 1941212 has been moved to the MODIFIED state.

In response to this:

Bug 1941212: The Multus daemonset should handle 10% maxUnavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

Hooray, here's count by (container,namespace,image) (kube_pod_container_info{container!="kube-rbac-proxy",namespace=~"openshift-multus|openshift-sdn"}) showing kube-multus transitioning from 4.7.3 to 4.8.0-fc.0 in ~12 minutes (with a bit of a metrics outage masking the beginning of the transition):

[wking]

/cherrypick release-4.6

[openshift-cherrypick-robot]

@wking: new pull request created: #1103

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.