Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1956352: [4.7] OVN kubernetes dual-stack conversion #1082

Merged

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Apr 30, 2021

Manual cherry-pick of #1034
We backported the ovnkube bits to 4.7 as part of openshift/ovn-kubernetes#460

Add a new annotation to the OVN kubernetes daemonsets, ovnkube-master
and ovnkube-node, indicating the IP family mode configured:

  • single-stack
  • dual-stack

This annotations allow to automate the conversion of one cluster from
single-stack to dual-stack and viceversa, since the change in the
annotation triggers a rollout of the daemonset.

Because the conversion requires to update the master daemonsets first,
we add the same logic used to manage the versions upgrades to this
process. The dual-stack conversion also blocks the upgrade, so both
are exclusive.

Add a new annotation to the OVN kubernetes daemonsets, ovnkube-master
and ovnkube-node, indicating the IP family mode configured:
- single-stack
- dual-stack

This annotations allow to automate the conversion of one cluster from
single-stack to dual-stack and viceversa, since the change in the
annotation triggers a rollout of the daemonset.

Because the conversion requires to update the master daemonsets first,
we add the same logic used to manage the versions upgrades to this
process. The dual-stack conversion also blocks the upgrade, so both
are exclusive.

Signed-off-by: Antonio Ojea <aojea@redhat.com>
(cherry picked from commit d9fb358)
@openshift-ci-robot
Copy link
Contributor

@dcbw: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[4.7] OVN kubernetes dual-stack conversion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021
@dcbw
Copy link
Contributor Author

dcbw commented Apr 30, 2021

@danwinship @aojea @trozet

@aojea
Copy link
Contributor

aojea commented May 1, 2021

It still need to switch the feature gate in the apiserver in this version

@aojea
Copy link
Contributor

aojea commented May 3, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dcbw dcbw changed the title [4.7] OVN kubernetes dual-stack conversion Bug 1956352: [4.7] OVN kubernetes dual-stack conversion May 3, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label May 3, 2021
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Bugzilla bug 1956352, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "4.6.z" instead
  • expected dependent Bugzilla bug 1937829 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1956352: [4.7] OVN kubernetes dual-stack conversion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 3, 2021
@dcbw
Copy link
Contributor Author

dcbw commented May 3, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Bugzilla bug 1956352, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1924171 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1924171 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 3, 2021
@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1aac65c into openshift:release-4.7 May 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2021

@dcbw: All pull requests linked via external trackers have merged:

Bugzilla bug 1956352 has been moved to the MODIFIED state.

In response to this:

Bug 1956352: [4.7] OVN kubernetes dual-stack conversion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants