New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1956352: [4.7] OVN kubernetes dual-stack conversion #1082
Bug 1956352: [4.7] OVN kubernetes dual-stack conversion #1082
Conversation
Add a new annotation to the OVN kubernetes daemonsets, ovnkube-master and ovnkube-node, indicating the IP family mode configured: - single-stack - dual-stack This annotations allow to automate the conversion of one cluster from single-stack to dual-stack and viceversa, since the change in the annotation triggers a rollout of the daemonset. Because the conversion requires to update the master daemonsets first, we add the same logic used to manage the versions upgrades to this process. The dual-stack conversion also blocks the upgrade, so both are exclusive. Signed-off-by: Antonio Ojea <aojea@redhat.com> (cherry picked from commit d9fb358)
@dcbw: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It still need to switch the feature gate in the apiserver in this version |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dcbw: This pull request references Bugzilla bug 1956352, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@dcbw: This pull request references Bugzilla bug 1956352, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dcbw: All pull requests linked via external trackers have merged: Bugzilla bug 1956352 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherry-pick of #1034
We backported the ovnkube bits to 4.7 as part of openshift/ovn-kubernetes#460
Add a new annotation to the OVN kubernetes daemonsets, ovnkube-master
and ovnkube-node, indicating the IP family mode configured:
This annotations allow to automate the conversion of one cluster from
single-stack to dual-stack and viceversa, since the change in the
annotation triggers a rollout of the daemonset.
Because the conversion requires to update the master daemonsets first,
we add the same logic used to manage the versions upgrades to this
process. The dual-stack conversion also blocks the upgrade, so both
are exclusive.