Bug 1970453: Replace to correct OpenFlow version when replacing flows #1111
Conversation
|
@alexanderConstantinescu: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@alexanderConstantinescu: GitHub didn't allow me to request PR reviews from the following users: alexanderConstantinescu. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
alexanderConstantinescu
force-pushed
the
bugfix/ovs-restore
branch
from
1e8b4e7
to
a4674b0
Compare
|
/retitle Bug 1970453: Replace to correct OpenFlow version when replacing flows |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
added
bugzilla/severity-high
|
@alexanderConstantinescu: This pull request references Bugzilla bug 1970453, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@alexanderConstantinescu: This pull request references Bugzilla bug 1970453, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @danwinship @squeed |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Well, I think it must have at one point...my suspicion is that openshift/sdn#238 broke it. |
mfojtik
added
the
cherry-pick-approved
|
[patch-manager] 🚀 Approved for z-stream by score: 1.20 approved |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@alexanderConstantinescu: All pull requests linked via external trackers have merged: Bugzilla bug 1970453 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The ovs-save script restoring flows when running OVS in a container on 4.6 defaults to OpenFlow14, which is not supported by openshift-sdn. This leads to flow restore errors on upgrades from 4.5 and hence a larger downtime window. See: openshift/sdn#306 (comment)
Force the script to use OpenFlow13, which is the only version of OpenFlow openshift-sdn supports.