Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1967994: Backport daemonset to drop icmp frag needed packets received from other nodes in the cluster to Rel 4.7 #1119

Merged
merged 2 commits into from Jun 17, 2021
Merged

Bug 1967994: Backport daemonset to drop icmp frag needed packets received from other nodes in the cluster to Rel 4.7 #1119

merged 2 commits into from Jun 17, 2021

Conversation

mccv1r0
Copy link
Contributor

@mccv1r0 mccv1r0 commented Jun 4, 2021 

Add daemonset to drop icmp frag needed packets received from other nodes in the cluster
Add logic to SDN to determine what platform we are running on.
Only use drop icmp frag needed daemonset when on Azure platform

Signed-off-by: Michael Cambria <mcambria@redhat.com>
(cherry picked from commit 401ea0cff5c967151e101bd97b4ac63cc46ac3e7)

Bug 1825219: Fix nil checks in bootstrapSDN
(cherry picked from commit 89cf5ffdbb34c0f43b86515e133becf2b92a8c45)

mccv1r0 and others added 2 commits June 4, 2021 10:52
@mccv1r0
Add daemonset to drop icmp frag needed packets received from other no…
9446679 
…des in the cluster

Add logic to SDN to determine what platform we are running on.
Only use drop icmp frag needed daemonset when on Azure platform

Signed-off-by: Michael Cambria <mcambria@redhat.com>
(cherry picked from commit 401ea0c)
@openshift-merge-robot @mccv1r0
Merge pull request openshift#1107 from Miciah/BZ1825219-fix-nil-check…
c46ec42 
…s-in-bootstrapSDN

Bug 1825219: Fix nil checks in bootstrapSDN

(cherry picked from commit 89cf5ff)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2021

@mccv1r0: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Backport daemonset to drop icmp frag needed packets received from other nodes in the cluster to Rel 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc knobunc changed the title Backport daemonset to drop icmp frag needed packets received from other nodes in the cluster to Rel 4.7 Bug 1967994: Backport daemonset to drop icmp frag needed packets received from other nodes in the cluster to Rel 4.7 Jun 4, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2021

@mccv1r0: This pull request references Bugzilla bug 1967994, which is invalid:

  • expected dependent Bugzilla bug 1825219 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1849736 to target a release in 4.8.0, but it targets "8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1967994: Backport daemonset to drop icmp frag needed packets received from other nodes in the cluster to Rel 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Jun 4, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2021

@knobunc: This pull request references Bugzilla bug 1967994, which is invalid:

  • expected dependent Bugzilla bug 1825219 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link
Contributor

knobunc commented Jun 4, 2021

/retest

@knobunc knobunc requested a review from Miciah June 4, 2021 16:43
@knobunc
Copy link
Contributor

knobunc commented Jun 4, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021
@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jun 4, 2021

/retest

1 similar comment
@knobunc
Copy link
Contributor

knobunc commented Jun 7, 2021

/retest

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jun 7, 2021

/test e2e-gcp-ovn

@anuragthehatter
Copy link

/bugzilla cc-qa

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2021

@anuragthehatter: This pull request references Bugzilla bug 1967994, which is invalid:

  • expected dependent Bugzilla bug 1825219 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhaozhanqi
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@zhaozhanqi
Copy link

/lgtm and /label qe-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, mccv1r0, zhaozhanqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@openshift-bot: An error was encountered querying GitHub for users with public email (zzhao@redhat.com) for bug 1967994 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhaozhanqi
Copy link

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@zhaozhanqi: This pull request references Bugzilla bug 1967994, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1825219 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1825219 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 16, 2021
@openshift-ci openshift-ci bot requested a review from zhaozhanqi June 16, 2021 01:52
@mfojtik
Copy link
Member

mfojtik commented Jun 16, 2021

[patch-manager] 🚀 Approved for z-stream by score: 2.50

approved

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 16, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7044920 into openshift:release-4.7 Jun 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@mccv1r0: All pull requests linked via external trackers have merged:

Bugzilla bug 1967994 has been moved to the MODIFIED state.

In response to this:

Bug 1967994: Backport daemonset to drop icmp frag needed packets received from other nodes in the cluster to Rel 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@dcbw dcbw Awaiting requested review from dcbw

@Miciah Miciah Awaiting requested review from Miciah

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@zhaozhanqi zhaozhanqi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mccv1r0 @knobunc @anuragthehatter @zhaozhanqi @openshift-bot @mfojtik @openshift-merge-robot