Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1973599: Escape characters on ini file #1137

Merged
merged 1 commit into from Jun 24, 2021
Merged

[release-4.6] Bug 1973599: Escape characters on ini file #1137

merged 1 commit into from Jun 24, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1127

/assign dulek

@MaysaMacedo
Escape characters on ini file
3482c55 
The configuration file supports variable substituion with oslo[1].
However, for the Kuryr scenario variables substituion wouldn't
happen as we expect the real value from the Secret. This commit
makes sure to escape the '$' caracter to avoid breaking oslo
parsing for the configuration file.

[1] https://github.com/openstack/oslo.config/blob/master/doc/source/configuration/format.rst#substitution
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 18, 2021
Merged
@openshift-ci openshift-ci bot requested review from aojea and dulek June 18, 2021 09:45
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@openshift-cherrypick-robot: Bugzilla bug 1969860 has been cloned as Bugzilla bug 1973599. Retitling PR to link against new bug.
/retitle [release-4.6] [release-4.7] Bug 1973599: Escape characters on ini file

In response to this:

[release-4.6] [release-4.7] Bug 1969860: Escape characters on ini file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.6] [release-4.7] Bug 1969860: Escape characters on ini file [release-4.6] [release-4.7] Bug 1973599: Escape characters on ini file Jun 18, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1973599, which is invalid:

  • expected dependent Bugzilla bug 1969860 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] [release-4.7] Bug 1973599: Escape characters on ini file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 18, 2021
@dulek
Copy link
Contributor

dulek commented Jun 18, 2021

/retitle [release-4.6] Bug 1973599: Escape characters on ini file

@openshift-ci openshift-ci bot changed the title [release-4.6] [release-4.7] Bug 1973599: Escape characters on ini file [release-4.6] Bug 1973599: Escape characters on ini file Jun 18, 2021
@dulek
Copy link
Contributor

dulek commented Jun 18, 2021

/retest

1 similar comment
@dulek
Copy link
Contributor

dulek commented Jun 21, 2021

/retest

@MaysaMacedo
Copy link
Contributor

/assign @trozet
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@trozet
Copy link
Contributor

trozet commented Jun 21, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaysaMacedo, openshift-cherrypick-robot, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@openshift-bot: This pull request references Bugzilla bug 1973599, which is invalid:

  • expected dependent Bugzilla bug 1969860 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@openshift-bot: This pull request references Bugzilla bug 1973599, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1969860 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1969860 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 23, 2021
@openshift-ci openshift-ci bot requested a review from eurijon June 23, 2021 01:01
@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit aa72781 into openshift:release-4.6 Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1973599 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1973599: Escape characters on ini file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@dulek dulek Awaiting requested review from dulek

@eurijon eurijon Awaiting requested review from eurijon

Assignees

@dulek dulek

@MaysaMacedo MaysaMacedo

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @dulek @MaysaMacedo @trozet @openshift-bot @bparees @openshift-merge-robot