Bug 1975016: Kuryr: Store OpenStack credentials in a secret #1139
Conversation
openshift-ci
bot
added
the
approved
|
/hold Let's see if this will need a bug. |
openshift-ci
bot
added
the
do-not-merge/hold
dulek
changed the title
|
@dulek: This pull request references Bugzilla bug 1975016, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-medium
|
I'll need to test an upgrade here too. |
|
/hold cancel Okay, upgrade works. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest BTW all those failures are flakes, we don't have CI testing Kuryr (yet). The jobs are incredibly unstable. |
| auth_type = {{ default "password" .OpenStackCloud.AuthType }} | ||
| auth_url = {{ $AuthInfo.AuthURL }} | ||
| insecure = {{ .OpenStackInsecureAPI }} | ||
| token = {{ default "\"\"" $AuthInfo.Token }} |
There was a problem hiding this comment.
we need to keep iniEscapeCharacters otherwise it will fail if $ is present
|
/hold I need to use |
openshift-ci
bot
added
the
do-not-merge/hold
This commit moves options filled with OpenStack credentials from a ConfigMap to a Secret and makes sure kuryr-controller gets it mounted.
dulek
force-pushed
the
kuryr-creds-secret
branch
from
f89bbc7
to
7ea1834
Compare
|
/retest |
|
/lgtm The hold can likely be removed now? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/recheck |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@dulek: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@dulek: All pull requests linked via external trackers have merged: Bugzilla bug 1975016 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit moves options filled with OpenStack credentials from a
ConfigMap to a Secret and makes sure kuryr-controller gets it mounted.