Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1982217: Use 10% for ovnkube-node for maxUnavailable #1153

Merged
merged 1 commit into from Jul 15, 2021
Merged

[release-4.7] Bug 1982217: Use 10% for ovnkube-node for maxUnavailable #1153

merged 1 commit into from Jul 15, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1000

/assign sdodson

@jluhrsen
Use 10% for ovnkube-node for maxUnavailable
5a15efa 
rolling update default is 1 and can be inefficient with
larger clusters

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 14, 2021
Merged
@sdodson
Copy link
Member

sdodson commented Jul 14, 2021

/lgtm
@jluhrsen Can I get an approval on this?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@openshift-cherrypick-robot: Bugzilla bug 1934711 has been cloned as Bugzilla bug 1982217. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1982217: Use 10% for ovnkube-node for maxUnavailable

In response to this:

[release-4.7] Bug 1934711: Use 10% for ovnkube-node for maxUnavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1934711: Use 10% for ovnkube-node for maxUnavailable [release-4.7] Bug 1982217: Use 10% for ovnkube-node for maxUnavailable Jul 14, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1982217, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1934711 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1934711 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

[release-4.7] Bug 1982217: Use 10% for ovnkube-node for maxUnavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi July 14, 2021 12:56
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2021
@jluhrsen
Copy link
Contributor

I don't have powers here to
/approve
but will try to find someone to do it.

@abhat
Copy link
Contributor

abhat commented Jul 14, 2021

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, jluhrsen, openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhat
Copy link
Contributor

abhat commented Jul 14, 2021

/retest

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 15, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jul 15, 2021

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 6fc6049 into openshift:release-4.7 Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1982217 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1982217: Use 10% for ovnkube-node for maxUnavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jul 19, 2021

/cherrypick release-4.6

@openshift-cherrypick-robot
Copy link
Author

@wking: new pull request created: #1157

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees

@sdodson sdodson

@abhat abhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @sdodson @jluhrsen @abhat @openshift-bot @wking @openshift-merge-robot