Bug 1984049: Slow OVN Recovery on SNO #1159

flavio-fernandes · 2021-07-20T19:49:14Z

Adding template OVN_DB_PROBE_INITIAL_DELAY parameter, which will set to 0 when there is only one master node.

Signed-off-by: Flavio Fernandes flaviof@redhat.com

openshift-ci · 2021-07-20T19:49:21Z

@flavio-fernandes: This pull request references Bugzilla bug 1984049, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

WIP: Bug 1984049: Slow OVN Recovery on SNO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

flavio-fernandes · 2021-07-21T05:00:38Z

/retest

flavio-fernandes · 2021-07-21T14:12:49Z

/retest

flavio-fernandes · 2021-07-21T15:07:21Z

pkg/network/ovn_kubernetes.go

@@ -82,6 +82,11 @@ func renderOVNKubernetes(conf *operv1.NetworkSpec, bootstrapResult *bootstrap.Bo
 	data.Data["OVN_NB_DB_LIST"] = dbList(bootstrapResult.OVN.MasterIPs, OVN_NB_PORT)
 	data.Data["OVN_SB_DB_LIST"] = dbList(bootstrapResult.OVN.MasterIPs, OVN_SB_PORT)
 	data.Data["OVN_DB_CLUSTER_INITIATOR"] = bootstrapResult.OVN.ClusterInitiator
+	if len(bootstrapResult.OVN.MasterIPs) == 1 {


As pointed out in the bug dispatch meeting, we seem to be doing this "len(bootstrapResult.OVN.MasterIPs)" call multiple times in the function. Ref: https://github.com/openshift/cluster-network-operator/pull/1154/commits
Maybe we should convert it ti a local variable?

flavio-fernandes · 2021-07-21T15:32:26Z

Rebasing to PR 1154 to remove duplicate logic in determining the number of masters.

flavio-fernandes · 2021-07-21T15:34:01Z

/assign @flavio-fernandes

abhat · 2021-07-22T21:19:47Z

/retest

flavio-fernandes · 2021-07-23T11:06:54Z

/retest

flavio-fernandes · 2021-07-26T16:01:33Z

/retest

knobunc · 2021-07-28T14:40:40Z

/retest
/approve

flavio-fernandes · 2021-08-02T19:32:42Z

/retest

openshift-bot · 2021-08-11T00:34:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T01:00:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T01:13:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T01:26:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T01:39:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T01:52:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T02:05:22Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T02:18:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T02:31:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T02:44:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T02:57:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T03:10:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T03:23:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T03:49:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T04:02:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T04:15:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T04:28:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T04:41:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T05:07:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T05:20:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T09:26:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T10:03:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T10:41:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-11T11:52:48Z

@flavio-fernandes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere-ovn	`cb2bde7`	link	`/test e2e-vsphere-ovn`
ci/prow/e2e-ovn-ipsec-step-registry	`cb2bde7`	link	`/test e2e-ovn-ipsec-step-registry`
ci/prow/e2e-openstack-ovn	`cb2bde7`	link	`/test e2e-openstack-ovn`
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec	`cb2bde7`	link	`/test e2e-metal-ipi-ovn-ipv6-ipsec`
ci/prow/e2e-ovn-step-registry	`cb2bde7`	link	`/test e2e-ovn-step-registry`
ci/prow/e2e-gcp-ovn-upgrade	`cb2bde7`	link	`/test e2e-gcp-ovn-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-08-11T12:37:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-11T13:43:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-11T14:58:12Z

@flavio-fernandes: All pull requests linked via external trackers have merged:

openshift/cluster-network-operator#1159

Bugzilla bug 1984049 has been moved to the MODIFIED state.

In response to this:

Bug 1984049: Slow OVN Recovery on SNO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jul 20, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 20, 2021

openshift-ci bot requested review from abhat and JacobTanenbaum July 20, 2021 19:49

flavio-fernandes force-pushed the bug1984049 branch 2 times, most recently from 567a2dd to 096af3b Compare July 20, 2021 21:59

flavio-fernandes changed the title ~~WIP: Bug 1984049: Slow OVN Recovery on SNO~~ Bug 1984049: Slow OVN Recovery on SNO Jul 20, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2021

flavio-fernandes commented Jul 21, 2021

View reviewed changes

flavio-fernandes force-pushed the bug1984049 branch from 096af3b to ed385e1 Compare July 21, 2021 15:29

openshift-ci bot assigned flavio-fernandes Jul 21, 2021

flavio-fernandes force-pushed the bug1984049 branch from ed385e1 to ac772a9 Compare July 22, 2021 15:42

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 28, 2021

flavio-fernandes force-pushed the bug1984049 branch from ac772a9 to 8abb965 Compare August 2, 2021 15:22

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2021

flavio-fernandes force-pushed the bug1984049 branch 3 times, most recently from 6d8b671 to 070a3c2 Compare August 3, 2021 19:27

openshift-ci bot merged commit 1fb2149 into openshift:master Aug 11, 2021

flavio-fernandes deleted the bug1984049 branch August 19, 2021 03:03

flavio-fernandes mentioned this pull request Sep 21, 2021

Bug 2008589: [4.8z] Slow OVN Recovery on SNO #1200

Merged

Bug 1984049: Slow OVN Recovery on SNO #1159

Bug 1984049: Slow OVN Recovery on SNO #1159

Conversation

flavio-fernandes commented Jul 20, 2021

openshift-ci bot commented Jul 20, 2021

flavio-fernandes commented Jul 21, 2021

flavio-fernandes commented Jul 21, 2021

flavio-fernandes Jul 21, 2021

Choose a reason for hiding this comment

flavio-fernandes commented Jul 21, 2021

flavio-fernandes commented Jul 21, 2021

abhat commented Jul 22, 2021

flavio-fernandes commented Jul 23, 2021

flavio-fernandes commented Jul 26, 2021

knobunc commented Jul 28, 2021

flavio-fernandes commented Aug 2, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-ci bot commented Aug 11, 2021 • edited

openshift-bot commented Aug 11, 2021

openshift-bot commented Aug 11, 2021

openshift-ci bot commented Aug 11, 2021

openshift-ci bot commented Aug 11, 2021 •

edited