Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1988427: Change to use mountPath: /host #1171

Merged
merged 1 commit into from Dec 1, 2021

Conversation

mccv1r0
Copy link
Contributor

@mccv1r0 mccv1r0 commented Jul 30, 2021

Change iptables chain names to not conflict with existing workaround(s)

Signed-off-by: Michael Cambria mcambria@redhat.com
(cherry picked from commit 32d72e5)

Change iptables chain names to not conflict with existing workaround(s)

Signed-off-by: Michael Cambria <mcambria@redhat.com>
(cherry picked from commit 32d72e5)
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@mccv1r0: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Change to use mountPath: /host

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from abhat and danwinship July 30, 2021 13:36
@mccv1r0 mccv1r0 changed the title Change to use mountPath: /host Bug 1988427: Change to use mountPath: /host Jul 30, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jul 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@mccv1r0: This pull request references Bugzilla bug 1988427, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "4.9.0" instead
  • expected dependent Bugzilla bug 1984449 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1984449 to target a release in 4.7.0, 4.7.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1988427: Change to use mountPath: /host

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 30, 2021
@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jul 30, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@mccv1r0: This pull request references Bugzilla bug 1988427, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "4.9.0" instead
  • expected dependent Bugzilla bug 1984449 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1984449 to target a release in 4.7.0, 4.7.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jul 30, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@mccv1r0: This pull request references Bugzilla bug 1988427, which is invalid:

  • expected dependent Bugzilla bug 1984449 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1984449 to target a release in 4.7.0, 4.7.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jul 30, 2021

/test e2e-azure-ovn
/test e2e-ovn-step-registry

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Jul 30, 2021

/test e2e-ovn-step-registry
/test e2e-azure-ovn

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Aug 10, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2021

@mccv1r0: This pull request references Bugzilla bug 1988427, which is invalid:

  • expected dependent Bugzilla bug 1988426 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Aug 24, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@sdodson: This pull request references Bugzilla bug 1988427, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1988426 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1988426 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 24, 2021
@openshift-ci openshift-ci bot requested a review from zhaozhanqi August 24, 2021 18:26
@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Sep 15, 2021

@dcbw Can you approve the 4.6 version of this backport or does someone else need to?

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Oct 8, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2021

@mccv1r0: This pull request references Bugzilla bug 1988427, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1988426 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1988426 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Nov 15, 2021

@abhat can you lgtm this backport so it can more along? It's already in 4.7 and beyond.

@dcbw
Copy link
Contributor

dcbw commented Nov 15, 2021

/approve

@dcbw
Copy link
Contributor

dcbw commented Nov 15, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, mccv1r0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@mccv1r0
Copy link
Contributor Author

mccv1r0 commented Nov 15, 2021

@zhaozhanqi @abhat : Can you guys move this cherry-pick backport along? Customer with this problem can't upgrade from 4.6 and needs to be able to ssh into Azure VMs

@zhaozhanqi
Copy link

@zhaozhanqi @abhat : Can you guys move this cherry-pick backport along? Customer with this problem can't upgrade from 4.6 and needs to be able to ssh into Azure VMs

backport-risk-assessed is needed firstly, then I can add cherry-pick-approved label

@trozet
Copy link
Contributor

trozet commented Nov 30, 2021

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 30, 2021
@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 1, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4b79ca0 into openshift:release-4.6 Dec 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

@mccv1r0: All pull requests linked via external trackers have merged:

Bugzilla bug 1988427 has been moved to the MODIFIED state.

In response to this:

Bug 1988427: Change to use mountPath: /host

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants