Bug 1997050: Fix panic with unknown networks #1188

errordeveloper · 2021-08-25T09:22:16Z

Make sure Bootstrap() returns an empty struct instead of a nil, and the unit test matches reality. Breakage was introduced in 403c4ff.

openshift-ci · 2021-08-25T09:22:19Z

@errordeveloper: This pull request references Bugzilla bug 1997050, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1997050: Fix panic with unknown networks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-25T09:22:44Z

Hi @errordeveloper. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-25T09:23:56Z

@errordeveloper: This pull request references Bugzilla bug 1997050, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1997050: Fix panic with unknown networks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Make sure `Bootstrap()` returns an empty struct instead of a nil, and the unit test matches reality. Breakage was introduced in 403c4ff.

vrutkovs · 2021-08-25T09:28:27Z

/ok-to-test
/bugzilla refresh

openshift-ci · 2021-08-25T09:29:34Z

@vrutkovs: This pull request references Bugzilla bug 1997050, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

/ok-to-test
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

errordeveloper · 2021-08-25T11:10:43Z

/test e2e-vsphere-ovn
/test e2e-gcp-ovn
/test e2e-ovn-hybrid-step-registry
/test e2e-aws-sdn-multi

errordeveloper · 2021-08-25T11:20:10Z

To me it looks like all these test failures are unrelated to the changes...

alexanderConstantinescu

To me it looks like all these test failures are unrelated to the changes...

Yes, seems like general CI flakiness. Given that this fixes your issue and does not impact the CNO in any way:

/lgtm

vrutkovs · 2021-08-25T13:53:38Z

/retest

squeed · 2021-08-25T14:31:29Z

/approve
good catch!

openshift-ci · 2021-08-25T14:39:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, errordeveloper, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [squeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-08-25T14:54:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-25T15:06:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

vrutkovs · 2021-08-25T15:16:29Z

/bugzilla refresh

openshift-ci · 2021-08-25T15:18:09Z

@vrutkovs: An error was encountered querying GitHub for users with public email (weliang@redhat.com) for bug 1997050 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-26T05:32:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T05:44:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T05:56:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T06:09:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T06:22:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T06:35:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T06:48:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T07:01:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T07:14:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T07:40:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

vrutkovs · 2021-08-26T07:50:55Z

/hold

e2e-agnostic-update is permafailing, needs an override

squeed · 2021-08-31T14:01:45Z

/override ci/prow/e2e-agnostic-upgrade
/hold cancel

openshift-ci · 2021-08-31T14:11:31Z

@squeed: Overrode contexts on behalf of squeed: ci/prow/e2e-agnostic-upgrade

In response to this:

/override ci/prow/e2e-agnostic-upgrade
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2021-08-31T17:02:34Z

/retest

dougbtv · 2021-08-31T20:15:44Z

/retest-required

openshift-bot · 2021-08-31T21:02:22Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-31T21:39:31Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-31T22:03:25Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-31T22:16:33Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-31T23:03:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-31T23:25:59Z

@errordeveloper: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure-ovn	`0d9f70f`	link	`/test e2e-azure-ovn`
ci/prow/e2e-gcp-ovn-upgrade	`0d9f70f`	link	`/test e2e-gcp-ovn-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vrutkovs · 2021-09-01T07:39:39Z

/skip
/retest

squeed · 2021-09-01T07:58:49Z

/override ci/prow/e2e-metal-ipi-ovn-ipv6
this PR clearly doesn't affect that.

openshift-ci · 2021-09-01T07:59:27Z

@squeed: Overrode contexts on behalf of squeed: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
this PR clearly doesn't affect that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-01T08:00:48Z

@errordeveloper: All pull requests linked via external trackers have merged:

openshift/cluster-network-operator#1188

Bugzilla bug 1997050 has been moved to the MODIFIED state.

In response to this:

Bug 1997050: Fix panic with unknown networks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Aug 25, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 25, 2021

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 25, 2021

openshift-ci bot requested review from alexanderConstantinescu and squeed August 25, 2021 09:23

Bug 1997050: Fix panic with unknown networks

0d9f70f

Make sure `Bootstrap()` returns an empty struct instead of a nil, and the unit test matches reality. Breakage was introduced in 403c4ff.

errordeveloper force-pushed the fix-unknown-network-render-panic branch from 8e8b647 to 0d9f70f Compare August 25, 2021 09:24

errordeveloper mentioned this pull request Aug 25, 2021

OpenShift 4.9 cilium/cilium-olm#49

Closed

alexanderConstantinescu approved these changes Aug 25, 2021

View reviewed changes

openshift-ci bot assigned alexanderConstantinescu Aug 25, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2021

openshift-merge-robot merged commit 7ed6dce into openshift:master Sep 1, 2021

errordeveloper deleted the fix-unknown-network-render-panic branch September 1, 2021 12:23

errordeveloper mentioned this pull request Sep 1, 2021

Upgrade Cilium to 1.10.3 openshift/release#21293

Merged

Bug 1997050: Fix panic with unknown networks #1188

Bug 1997050: Fix panic with unknown networks #1188

Conversation

errordeveloper commented Aug 25, 2021 • edited

openshift-ci bot commented Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

vrutkovs commented Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

errordeveloper commented Aug 25, 2021

errordeveloper commented Aug 25, 2021 • edited

alexanderConstantinescu left a comment

Choose a reason for hiding this comment

vrutkovs commented Aug 25, 2021

squeed commented Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

openshift-bot commented Aug 25, 2021

openshift-bot commented Aug 25, 2021

vrutkovs commented Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

openshift-bot commented Aug 26, 2021

openshift-bot commented Aug 26, 2021

openshift-bot commented Aug 26, 2021

openshift-bot commented Aug 26, 2021

openshift-bot commented Aug 26, 2021

openshift-bot commented Aug 26, 2021

openshift-bot commented Aug 26, 2021

openshift-bot commented Aug 26, 2021

openshift-bot commented Aug 26, 2021

openshift-bot commented Aug 26, 2021

vrutkovs commented Aug 26, 2021

squeed commented Aug 31, 2021

openshift-ci bot commented Aug 31, 2021

vrutkovs commented Aug 31, 2021

dougbtv commented Aug 31, 2021

openshift-bot commented Aug 31, 2021

openshift-bot commented Aug 31, 2021

openshift-bot commented Aug 31, 2021

openshift-bot commented Aug 31, 2021

openshift-bot commented Aug 31, 2021

openshift-ci bot commented Aug 31, 2021 • edited

vrutkovs commented Sep 1, 2021

squeed commented Sep 1, 2021

openshift-ci bot commented Sep 1, 2021

openshift-ci bot commented Sep 1, 2021

errordeveloper commented Aug 25, 2021 •

edited

errordeveloper commented Aug 25, 2021 •

edited

openshift-ci bot commented Aug 31, 2021 •

edited