[release-4.7] Bug 2041893: Allow to use proxy to connect to OSP cloud

[MaysaMacedo]

When using Proxy and the installer is configured
on a restricted installation, Kuryr bootstrap
can't progress as the http client is not
configured to use Proxy. This commit ensures
proxy is used by relying on the cluster proxy
resource instead of relying on cvo to injecting
the proxy env vars.

[openshift-ci]

@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Allow to use proxy to connect to OSP cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

Manual backport of #1225

[MaysaMacedo]

/test e2e-openstack-kuryr

[openshift-ci]

@MaysaMacedo: This pull request references Bugzilla bug 2041893, which is invalid:

• expected dependent Bugzilla bug 2022747 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
• expected dependent Bugzilla bug 2014021 to target a release in 4.8.0, 4.8.z, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2041893: Allow to use proxy to connect to OSP cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

/retest
/cc @dulek

[MaysaMacedo]

/bugzilla refresh

[openshift-ci]

@MaysaMacedo: This pull request references Bugzilla bug 2041893, which is invalid:

• expected dependent Bugzilla bug 2014021 to target a release in 4.8.0, 4.8.z, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dulek]

/bugzilla refresh

[openshift-ci]

@dulek: This pull request references Bugzilla bug 2041893, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2022747 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2022747 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
• bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

/retest
/assign @danwinship

[MaysaMacedo]

/cc @alexanderConstantinescu

[openshift-ci]

@MaysaMacedo: GitHub didn't allow me to request PR reviews from the following users: alexanderConstantinescu.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @alexanderConstantinescu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danwinship]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MaysaMacedo]

/cc @trozet
Can you evaluate the backport-risk-assessed?

[jcaamano]

/label backport-risk-assessed

[MaysaMacedo]

@anuragthehatter if you see fit, can you apply the cherry-pick-approved label here?
Thanks

[MaysaMacedo]

/cc @anuragthehatter

[anuragthehatter]

/label cherry-pick-approved

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[MaysaMacedo]

/test e2e-metal-ipi-ovn-ipv6

[openshift-ci]

@MaysaMacedo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@MaysaMacedo: All pull requests linked via external trackers have merged:

• openshift/cluster-network-operator#1284

Bugzilla bug 2041893 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 2041893: Allow to use proxy to connect to OSP cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@MaysaMacedo: #1284 failed to apply on top of branch "release-4.6":

Applying: Allow to use proxy to connect to OSP cloud
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	pkg/bootstrap/types.go
M	pkg/network/kuryr.go
M	pkg/platform/openstack/kuryr_bootstrap.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging pkg/platform/openstack/kuryr_bootstrap.go
Auto-merging pkg/network/kuryr.go
Auto-merging pkg/bootstrap/types.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow to use proxy to connect to OSP cloud
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.