Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2058673: ip-reconciler cronjob specification requires hostnetwork, api-int lb usage & proper backoff [backport 4.9] #1323

Merged
merged 3 commits into from Apr 18, 2022
Merged

Bug 2058673: ip-reconciler cronjob specification requires hostnetwork, api-int lb usage & proper backoff [backport 4.9] #1323

merged 3 commits into from Apr 18, 2022

Commits on Feb 25, 2022

  1. whereabouts, reconciler: disable retries on failure 

    The `backoffLimit` attribute - [0] - "specifies the number of retries
before marking this job failed. Defaults to 6."

The aforementioned attribute belongs to `jobTemplate.spec`, not to the
pod's spec template.

[0] - https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#lifecycle

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
    @maiqueb @dougbtv
    maiqueb authored and dougbtv committed Feb 25, 2022
    Copy the full SHA
    3e265e3 View commit details
    Browse the repository at this point in the history

  2. The Whereabouts ip-reconciler should use the internal load balancer a… 

    …nd host network

This gives it connectivity during cluster lifecycle events where the SDN is in a transitioning state.
    @dougbtv
    dougbtv committed Feb 25, 2022
    Copy the full SHA
    c18617d View commit details
    Browse the repository at this point in the history

  3. ip reconciler: auto clean failed jobs 

    This commit makes use of the `ttlSecondsAfterFinished` knob to auto clean
the failed jobs.

According to the Kubernetes API documentation - [0] - this property:
"""
limits the lifetime of a Job that has finished execution (either Complete or
Failed). If this field is set, ttlSecondsAfterFinished after the Job finishes,
it is eligible to be automatically deleted. When the Job is being deleted, its
lifecycle guarantees (e.g. finalizers) will be honored. If this field is unset,
the Job won't be automatically deleted. If this field is set to zero, the Job
becomes eligible to be deleted immediately after it finishes.
"""

We're leaving the failed job around for 15 minutes - which is the period
of the cron job.

[0] - https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#JobSpec

Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
    @maiqueb @dougbtv
    maiqueb authored and dougbtv committed Feb 25, 2022
    Copy the full SHA
    10dc83a View commit details
    Browse the repository at this point in the history