Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2089805: Enable config duration for OVN-Kubernetes #1455

Conversation

martinkennelly
Copy link
Contributor

@martinkennelly martinkennelly commented May 24, 2022

This will enable the following bucket metrics:
ovnkube_master_network_programming_ovn_duration_seconds_*
ovnkube_master_network_programming_duration_seconds_*

We have carried out initial testing at scale with ~5k pods to show the perf
regression is minimal.

Signed-off-by: Martin Kennelly mkennell@redhat.com

/cc @npinaeva @bmeng

@openshift-ci openshift-ci bot requested review from bmeng and npinaeva May 24, 2022 13:40
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2022

@martinkennelly: This pull request references Bugzilla bug 2089805, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Bug 2089805: Enable config duration for OVN-K SD deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor

@martinkennelly the ovn-kubernetes/managed manifests are only for hypershift, does SD use non-hypershift manifests (self-hosted) ?

@martinkennelly
Copy link
Contributor Author

/hold

@zshi-redhat Thank you. Looks like I am misunderstanding the file structure here. I do not believe they are using hypershift but I will confirm.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
This will enable the following bucket metrics:
ovnkube_master_network_programming_ovn_duration_seconds_*
ovnkube_master_network_programming_duration_seconds_*

Signed-off-by: Martin Kennelly <mkennell@redhat.com>
@martinkennelly martinkennelly changed the title Bug 2089805: Enable config duration for OVN-K SD deployment Bug 2089805: Enable config duration for OVN-Kubernetes May 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2022

@martinkennelly: This pull request references Bugzilla bug 2089805, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Bug 2089805: Enable config duration for OVN-Kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2022

@martinkennelly: This pull request references Bugzilla bug 2089805, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Bug 2089805: Enable config duration for OVN-Kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@martinkennelly
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
@zshi-redhat
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2022
@bmeng
Copy link
Contributor

bmeng commented May 25, 2022

Hi @zshi-redhat @martinkennelly
SD will start to use the hypershift for internal testing purpose. So I think making it available for both managed clusters and hosted clusters should make sense.

@npinaeva
Copy link
Member

/lgtm

@martinkennelly
Copy link
Contributor Author

/retest

@jcaamano
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, martinkennelly, npinaeva, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD bc1d913 and 8 for PR HEAD 3f3a15f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD bc1d913 and 7 for PR HEAD 3f3a15f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bc1d913 and 6 for PR HEAD 3f3a15f in total

@martinkennelly
Copy link
Contributor Author

/test e2e-aws-ovn-windows

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD bc1d913 and 8 for PR HEAD 3f3a15f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD bc1d913 and 7 for PR HEAD 3f3a15f in total

@martinkennelly
Copy link
Contributor Author

/hold

Waiting for SDN rebase to fix kubelet version test in the windows CI job.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2022
@martinkennelly
Copy link
Contributor Author

/retest

Hoping this PR fixes it: openshift/windows-machine-config-operator#1085

@martinkennelly
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 26c2a62 and 6 for PR HEAD 3f3a15f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 26c2a62 and 5 for PR HEAD 3f3a15f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 26c2a62 and 4 for PR HEAD 3f3a15f in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2022

@martinkennelly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-windows 3f3a15f link false /test e2e-aws-ovn-windows
ci/prow/e2e-aws-upgrade 3f3a15f link false /test e2e-aws-upgrade
ci/prow/e2e-openstack-ovn 3f3a15f link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e4b8771 into openshift:master Jun 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2022

@martinkennelly: All pull requests linked via external trackers have merged:

Bugzilla bug 2089805 has been moved to the MODIFIED state.

In response to this:

Bug 2089805: Enable config duration for OVN-Kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants