New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2089805: Enable config duration for OVN-Kubernetes #1455
Bug 2089805: Enable config duration for OVN-Kubernetes #1455
Conversation
@martinkennelly: This pull request references Bugzilla bug 2089805, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@martinkennelly the ovn-kubernetes/managed manifests are only for hypershift, does SD use non-hypershift manifests (self-hosted) ? |
/hold @zshi-redhat Thank you. Looks like I am misunderstanding the file structure here. I do not believe they are using hypershift but I will confirm. |
This will enable the following bucket metrics: ovnkube_master_network_programming_ovn_duration_seconds_* ovnkube_master_network_programming_duration_seconds_* Signed-off-by: Martin Kennelly <mkennell@redhat.com>
c45daa4
to
3f3a15f
Compare
@martinkennelly: This pull request references Bugzilla bug 2089805, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@martinkennelly: This pull request references Bugzilla bug 2089805, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold |
/lgtm |
Hi @zshi-redhat @martinkennelly |
/lgtm |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, martinkennelly, npinaeva, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws-ovn-windows |
/hold Waiting for SDN rebase to fix kubelet version test in the windows CI job. |
/retest Hoping this PR fixes it: openshift/windows-machine-config-operator#1085 |
/unhold |
@martinkennelly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@martinkennelly: All pull requests linked via external trackers have merged: Bugzilla bug 2089805 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will enable the following bucket metrics:
ovnkube_master_network_programming_ovn_duration_seconds_*
ovnkube_master_network_programming_duration_seconds_*
We have carried out initial testing at scale with ~5k pods to show the perf
regression is minimal.
Signed-off-by: Martin Kennelly mkennell@redhat.com
/cc @npinaeva @bmeng