Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2092265: Cleanup CNO relatedObjects #1468

Merged
merged 1 commit into from Jul 1, 2022
Merged

[release-4.9] Bug 2092265: Cleanup CNO relatedObjects #1468

merged 1 commit into from Jul 1, 2022

Conversation

npinaeva
Copy link
Member

@npinaeva npinaeva commented Jun 1, 2022

Backport of #1432

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@npinaeva: This pull request references Bugzilla bug 2092265, which is invalid:

  • expected dependent Bugzilla bug 2084591 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2023295 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2092265: Cleanup CNO relatedObjects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva npinaeva mentioned this pull request Jun 1, 2022
Merged
@npinaeva
Remove NetworkPolicy, EgressFirewall, and EgressIP
50c0791 
from CNO relatedObjects
Don't delete relatedObjects without a name

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
(cherry picked from commit 62af15d)
@npinaeva
Copy link
Member Author

/bugzilla refresh

@npinaeva
Copy link
Member Author

/retest-required

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2022

@npinaeva: This pull request references Bugzilla bug 2092265, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2084591 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2084591 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @huiran0826

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from huiran0826 June 24, 2022 08:31
This was referenced Jun 24, 2022
Merged
Merged
@flavio-fernandes
Copy link
Contributor

Based on #1432 ....
/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2022
@npinaeva
Copy link
Member Author

/retest-required

@flavio-fernandes
Copy link
Contributor

/test e2e-gcp-ovn

1 similar comment
@flavio-fernandes
Copy link
Contributor

/test e2e-gcp-ovn

@huiran0826
Copy link

Tested PR , however, EgressIP yaml was not collected. Details please see :https://bugzilla.redhat.com/show_bug.cgi?id=2092265#c2

@huiran0826
Copy link

EgressIP yaml was collected by oc adm must-gather -- gather_network_logs
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 27, 2022
@npinaeva
Copy link
Member Author

/retest-required

@trozet
Copy link
Contributor

trozet commented Jun 28, 2022

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2022
@npinaeva
Copy link
Member Author

/retest-required

@huiran0826
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 29, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 09aa25d and 8 for PR HEAD 50c0791 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 09aa25d and 7 for PR HEAD 50c0791 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 09aa25d and 6 for PR HEAD 50c0791 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2022 •
edited

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade 50c0791 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-vsphere-ovn 50c0791 link false /test e2e-vsphere-ovn
ci/prow/e2e-ovn-ipsec-step-registry 50c0791 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-ovn-hybrid-step-registry 50c0791 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-azure-ovn 50c0791 link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@npinaeva
Copy link
Member Author

npinaeva commented Jul 1, 2022

ci/prow/e2e-gcp-ovn is perma-failing since June 1, tracking BZ https://bugzilla.redhat.com/show_bug.cgi?id=2097735

@jcaamano
Copy link
Contributor

jcaamano commented Jul 1, 2022

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 648e6d2 into openshift:release-4.9 Jul 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

@npinaeva: All pull requests linked via external trackers have merged:

Bugzilla bug 2092265 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2092265: Cleanup CNO relatedObjects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv Awaiting requested review from dougbtv

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@huiran0826 huiran0826 Awaiting requested review from huiran0826

Assignees

@flavio-fernandes flavio-fernandes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@npinaeva @flavio-fernandes @huiran0826 @trozet @openshift-ci-robot @jcaamano