Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configmap list/watch rights to cloud-network-config-controller #1511

Merged
merged 1 commit into from Jul 20, 2022
Merged

Add configmap list/watch rights to cloud-network-config-controller #1511

merged 1 commit into from Jul 20, 2022

Conversation

andreaskaris
Copy link
Contributor 

The OpenStack CNCC provider plugin requires a ConfigMap that provides
an additional CA certificate. The CNCC must monitor ConfigMaps in its
namespace for changes. Add list/watch rights to the CNCC ServiceAccount
for the CNCC namespace.

Signed-off-by: Andreas Karis ak.karis@gmail.com

@andreaskaris
Add configmap list/watch rights to cloud-network-config-controller
bb1c88b 
The OpenStack CNCC provider plugin requires a ConfigMap that provides
an additional CA certificate. The CNCC must monitor ConfigMaps in its
namespace for changes. Add list/watch rights to the CNCC ServiceAccount
for the CNCC namespace.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@openshift-ci openshift-ci bot requested review from dougbtv and tssurya July 18, 2022 16:01
@andreaskaris
Copy link
Contributor Author

/retest

flavio-fernandes
flavio-fernandes reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@flavio-fernandes flavio-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@andreaskaris
Copy link
Contributor Author

/retest-failed

@andreaskaris
Copy link
Contributor Author

/retest-required

@jcaamano
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreaskaris, flavio-fernandes, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@andreaskaris
Copy link
Contributor Author

/retest-required

1 similar comment
@andreaskaris
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 2212a26 and 8 for PR HEAD bb1c88b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 2212a26 and 7 for PR HEAD bb1c88b in total

@andreaskaris andreaskaris reopened this Jul 20, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2212a26 and 6 for PR HEAD bb1c88b in total

@andreaskaris
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

@andreaskaris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn bb1c88b link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec bb1c88b link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-azure-ovn bb1c88b link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 44d7f1e into openshift:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio-fernandes flavio-fernandes flavio-fernandes left review comments

@dougbtv dougbtv Awaiting requested review from dougbtv

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@flavio-fernandes flavio-fernandes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andreaskaris @jcaamano @openshift-ci-robot @flavio-fernandes @openshift-merge-robot